SpanMetrics converter: include http.request.status_code as metric attribute

[mariomac]

Component(s)

processor/spanmetrics

Is your feature request related to a problem? Please describe.

After converting my HTTP request traces to metrics, we expected that the status_code field contained the HTTP response status (e.g. 200, 404, etc...). After digging into it, we realized that it actually contains the Unset, Ok and Error values about the Span status.

Describe the solution you'd like

I'd suggest that status_code metrics attribute value is set from http.request.status_code (or e.g. rpc.grpc.status_code for GRPC services).

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• processor/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[albertteoh]

status_code is part of the OTEL trace specification, and I think it's important to stay true to that; moreover, because that value is always present, we can rely on it as one of the "standard" dimensions of a metric.

On the other hand, http.request.status_code is not guaranteed to be present, so I don't think we can rely on it for status codes.

Have you tried adding http.request.status_code to the dimensions configuration of the spanmetricsconnector? Example: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/connector/spanmetricsconnector/README.md#examples.

[mariomac]

No I didn't try, as I was working on a managed instance. But thank you for the explanation and the exposition of the solution!

[github-actions]

Pinging code owners for connector/spanmetrics: @albertteoh @kovrus. See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

• processor/spanmetrics: @albertteoh
• connector/spanmetrics: @albertteoh

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[github-actions]

This issue has been closed as inactive because it has been stale for 120 days with no activity.