Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/spanmetrics] spanmetrics connector do not attach exemplar any more #20771

Closed
fatsheep9146 opened this issue Apr 10, 2023 · 1 comment · Fixed by #20772
Closed

[connector/spanmetrics] spanmetrics connector do not attach exemplar any more #20771

fatsheep9146 opened this issue Apr 10, 2023 · 1 comment · Fixed by #20772
Assignees
Labels
bug Something isn't working connector/spanmetrics

Comments

@fatsheep9146
Copy link
Contributor

Component(s)

connector/spanmetrics

What happened?

Description

After using spanmetrics connector instead of spanmetrics processor, I found that exemplar info are no longer attached to metrics.

I tried to dig and find the possible root cause is

for i := 0; i < dp.Exemplars().Len(); i++ {
dp.Exemplars().At(i).SetTimestamp(timestamp)

and I already tried to fix it and send a pr. Please correct me if I do it wrong.

Steps to Reproduce

Just use the basic usage of spanmetrics connector and use prometheus receiver, check about the exemplar info on prometheus ui, you will find exemplar info can not be displayed

Expected Result

Actual Result

Collector version

0.75.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@fatsheep9146 fatsheep9146 added bug Something isn't working needs triage New item requiring triage labels Apr 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@fatsheep9146 fatsheep9146 self-assigned this Apr 10, 2023
@fatsheep9146 fatsheep9146 removed the needs triage New item requiring triage label Apr 10, 2023
@fatsheep9146 fatsheep9146 changed the title [spanmetrics connector] spanmetrics connector do not attach exemplar any more [connector/spanmetrics] spanmetrics connector do not attach exemplar any more Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working connector/spanmetrics
Projects
None yet
1 participant