Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/telemetrygen] log subcommand support --otlp-insecure flag to be true #18868

Closed
fatsheep9146 opened this issue Feb 21, 2023 · 7 comments
Closed
Labels
cmd/telemetrygen telemetrygen command data:logs Logs related issues enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed

Comments

@fatsheep9146
Copy link
Contributor

Component(s)

cmd/telemetrygen

Is your feature request related to a problem? Please describe.

telemetrygen log subcommand should support --otlp-insecure flag to true, in order to send data with tls configuration.

Describe the solution you'd like

telemetrygen log subcommand should support --otlp-insecure flag to true, in order to send data with tls configuration.

Describe alternatives you've considered

No response

Additional context

No response

@fatsheep9146 fatsheep9146 added enhancement New feature or request needs triage New item requiring triage labels Feb 21, 2023
@github-actions github-actions bot added the cmd/telemetrygen telemetrygen command label Feb 21, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 25, 2023
@mx-psi mx-psi removed the Stale label Apr 25, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 26, 2023
@mx-psi mx-psi added data:logs Logs related issues and removed Stale labels Jun 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 28, 2023
@mx-psi mx-psi added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Aug 28, 2023
@graphaelli
Copy link
Contributor

This should be flipped - allow --otlp-insecure to be false. Right now it must be true for logs.

@Frapschen
Copy link
Contributor

Close as already implemented in https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/cmd/telemetrygen/internal/common/config.go#L122.

If anyone has any other questions, please reopen.

@graphaelli
Copy link
Contributor

Thanks, looks like this was fixed by #29681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/telemetrygen telemetrygen command data:logs Logs related issues enhancement New feature or request never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

No branches or pull requests

5 participants