Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors/spanmetrics] Drop _total from generated metrics names. #18677

Closed
kovrus opened this issue Feb 15, 2023 · 5 comments
Closed

[connectors/spanmetrics] Drop _total from generated metrics names. #18677

kovrus opened this issue Feb 15, 2023 · 5 comments
Labels
connector/spanmetrics needs triage New item requiring triage processor/spanmetrics Span Metrics processor

Comments

@kovrus
Copy link
Member

kovrus commented Feb 15, 2023

Component(s)

connector/spanmetrics

Describe the issue you're reporting

Description

The spanmeterics connector generates a metric with _total which is done to follow the Prometheus naming convention. The spanmeterics connector is OTel component and should be agnostic to any downstream components, we would like to drop _total from metrics names. In the case of Prometheus exporters, exporters will automatically add _total where it is needed. See discussion #18199 (comment)

It is the change that will be done in the new (not yet enabled) component, so it does not break anything for the existing users. However, we have to inform users about these changes when migrating from spanmeterics processor to spanmeterics connector.

@kovrus kovrus added needs triage New item requiring triage processor/spanmetrics Span Metrics processor labels Feb 15, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

Pinging code owners for processor/spanmetrics: @albertteoh. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@kovrus
Copy link
Member Author

kovrus commented Feb 15, 2023

cc: @claus @albertteoh

@albertteoh
Copy link
Contributor

cc: @Cluas

@djaglowski
Copy link
Member

Closed by #18744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector/spanmetrics needs triage New item requiring triage processor/spanmetrics Span Metrics processor
Projects
None yet
Development

No branches or pull requests

3 participants