Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/awsxray] set service.name attributes #18480

Closed
p1ass opened this issue Feb 9, 2023 · 2 comments
Closed

[receiver/awsxray] set service.name attributes #18480

p1ass opened this issue Feb 9, 2023 · 2 comments
Labels
enhancement New feature or request receiver/awsxray

Comments

@p1ass
Copy link
Contributor

p1ass commented Feb 9, 2023

Component(s)

receiver/awsxray

Is your feature request related to a problem? Please describe.

When using the awsxray receiver, the required service name attribute is not set.
As a result, when I view traces, it is not always clear which service it is.

Describe the solution you'd like

Copy the value of the Name field of awsxray.Segment to Resource attribute.

Describe alternatives you've considered

No response

Additional context

No response
@p1ass p1ass added enhancement New feature or request needs triage New item requiring triage labels Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@p1ass p1ass mentioned this issue Feb 9, 2023
Merged
@atoulme atoulme removed the needs triage New item requiring triage label Mar 7, 2023
@atoulme
Copy link
Contributor

atoulme commented Mar 7, 2023

Marking as fixed, thanks @p1ass !

@atoulme atoulme closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request receiver/awsxray
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atoulme @p1ass