Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are not up-to-date #16613

Open
alexandrebrg opened this issue Dec 5, 2022 · 5 comments · Fixed by #16809
Open

Examples are not up-to-date #16613

alexandrebrg opened this issue Dec 5, 2022 · 5 comments · Fixed by #16809
Assignees
Labels
bug Something isn't working examples/demo never stale Issues marked with this label will be never staled and automatically removed

Comments

@alexandrebrg
Copy link

Component(s)

examples/demo

What happened?

Description

Some examples of this repository are either not working anymore or are out-of-date. I've been experiencing issues with exporters.logging.verbosity key which has been added recently but isn't working in few examples (see slack discussion).

I've made a tour of the examples to check whether they are out-of-date or not working anymore, results are in #Actual Result.

Steps to Reproduce

For not working examples:

  1. Be at the root of the repository
  2. Run docker compose -f examples/${EXAMPLE_NAME}/docker-compose.yml

To check whether it is up-to-date or not (reading Dockerfile / docker-compose.yml works too):

  1. Be at the root of the repository
  2. Update the example configuration by adding the following exporter (this piece of config is recent enough to check if images are up to date):
exporters:
    logging:
        verbosity: detailed
  1. Run docker compose up -f examples/${EXAMPLE_NAME}/docker-compose.yml

Expected Result

All examples should be working and up-to-date.

Actual Result

Example name Is working Is up-to-date
couchbase
demo
kubernetes Unknown Unknown
nomad Unknown Unknown
tracegen
tracing

There is no input for kubernetes and nomad, new inputs for them are welcomed!

Couchbase error

$ opentelemetry-collector-contrib/ docker compose up -f examples/couchbase/docker-compose.yml
1 error(s) decoding:

* 'Deploy.Resources.Limits.cpus' expected type 'string', got unconvertible type 'float64', value: '0.5'

Tracegen error

$ opentelemetry-collector-contrib/examples/tracegen docker compose up
unable to prepare context: path "../../tracegen" not found

Demo out-of-date

It is running image otel/opentelemetry-collector-contrib-dev:latest which hasn't been updated for a long time, it should be updated or using Dockerfile from tracing example.

Collector version

e58554a

Environment information

Environment

OS: MacOS, v13.0.1
Compiler(if manually compiled): go1.19.3
Arch: arm64 (Apple Silicon M1)

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@alexandrebrg alexandrebrg added bug Something isn't working needs triage New item requiring triage labels Dec 5, 2022
@fatsheep9146 fatsheep9146 added examples/demo and removed needs triage New item requiring triage labels Dec 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

Pinging code owners for examples/demo: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jackycsl
Copy link
Contributor

jackycsl commented Dec 7, 2022

Can I work on this issue, getting the demo example up to date?

@fatsheep9146
Copy link
Contributor

It's yours! @jackycsl

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2022

I shouldn't have linked this since I assume there will be other PRs needed for the rest of examples. Reopening...

@mx-psi mx-psi reopened this Dec 12, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • examples/demo: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 13, 2023
@jpkrohling jpkrohling added the never stale Issues marked with this label will be never staled and automatically removed label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working examples/demo never stale Issues marked with this label will be never staled and automatically removed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants