Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the jar files in testdata #16281

Closed
sandy2008 opened this issue Nov 14, 2022 · 7 comments
Closed

Removing the jar files in testdata #16281

sandy2008 opened this issue Nov 14, 2022 · 7 comments

Comments

@sandy2008
Copy link

Component(s)

receiver/jmx

Describe the issue you're reporting

In https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/jmxreceiver/testdata, we can find multiple jar files in the folder which will eventually create security issues and make the repo larger with the binaries.

Can we put everything in a Dockerfile and make it into an image?

@sandy2008 sandy2008 added the needs triage New item requiring triage label Nov 14, 2022
@github-actions github-actions bot added the receiver/jmx JMX Receiver label Nov 14, 2022
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@rmfitzpatrick
Copy link
Contributor

@sandy2008 these aren't actual jars (hence the fake_ prefix) are used to test functionality added in #9985

@codeboten
Copy link
Contributor

It appears the files are negligible in size, is this still a problem?

$ ls -alh receiver/jmxreceiver/testdata
-rw-r--r--   1      7B Sep 23 09:48 fake_additional.jar
-rw-r--r--   1      5B Sep 23 09:48 fake_jmx.jar
-rw-r--r--   1     10B Sep 23 09:48 fake_jmx_wrong.jar

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 16, 2023
@atoulme atoulme added waiting for author and removed needs triage New item requiring triage labels Mar 8, 2023
@github-actions github-actions bot removed the Stale label May 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@rmfitzpatrick
Copy link
Contributor

I think this can be closed as a non-issue.

@github-actions github-actions bot removed the Stale label Jul 27, 2023
@codeboten
Copy link
Contributor

👍🏻 sounds good @rmfitzpatrick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants