Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awsxray] Favour semconv attributes when populating Queue URL and Table Name #16075

Closed
lukestoward opened this issue Nov 4, 2022 · 2 comments

Comments

@lukestoward
Copy link
Contributor

Component(s)

exporter/awsxray

Describe the issue you're reporting

Currently the awsxray exporter is looking for X-Ray custom attribute keys when populating the queueURL and tableName properties during the translation between OTel and X-Ray formats. Some instrumentation libraries, such as the aws-sdk-go-v2/otelaws do not set the X-Ray custom attributes, but instead set the relevant Semantic Convention attributes. However, as the awsxray exporter is not looking for these attributes, the data is not translated and exported.

I recently raised a PR on the aws-sdk-go-v2/otelaws instrumentation library to add the X-Ray custom attributes, however, it was agreed that we should instead use the relevant semantic convention attributes instead and update the exporter to extract these values.

@lukestoward lukestoward added the needs triage New item requiring triage label Nov 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@lukestoward
Copy link
Contributor Author

Associated PR #16076 has been merged. Issue resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants