Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS resource detection processor - add tags #14960

Closed
mattk-ce opened this issue Oct 14, 2022 · 6 comments
Closed

ECS resource detection processor - add tags #14960

mattk-ce opened this issue Oct 14, 2022 · 6 comments

Comments

@mattk-ce
Copy link

Is your feature request related to a problem? Please describe.

There is a significant disparity between the EC2 resource detection processor and ECS - EC2 supports tag metadata, ECS does not. When creating Fargate ECS tasks, this means you're left with replicating tags as environment variables for label extraction.

Describe the solution you'd like

It could be as simple as modifying the TaskMetadataPath to be /taskWithTags. Or, more likely, make it somehow configurable?

Describe alternatives you've considered

Replicate the necessary tags as environment variables for label extraction via the env resource detection processor.

Additional context

No response

@mattk-ce mattk-ce added enhancement New feature or request needs triage New item requiring triage labels Oct 14, 2022
@evan-bradley evan-bradley added priority:p2 Medium receiver/awsecscontainermetrics and removed needs triage New item requiring triage labels Oct 17, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @Aneurysm9. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 19, 2022
@mattk-ce
Copy link
Author

Still desperately needed.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Mar 14, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
@mcaxtrzen
Copy link

That would be very convenient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants