-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/elasticsearchreceiver]: add support for more metrics #14635
Comments
Pinging code owners: @djaglowski @BinaryFissionGames. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@djaglowski I've added the pull requests I've been able to do right now. The remaining metrics are:
|
We can have this in addition to the max and used metrics. However, it should be disabled by default.
I think getting it from the API is better, as long as it doesn't add unreasonable load or require much additional config. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
@aboguszewski-sumo, it's not clear to me whether this work has been completed. If it has, please close the issue. |
@djaglowski technically this is completed, but I wanted to keep the issue open until the feature gates related to it are removed (which should happen in |
Is your feature request related to a problem? Please describe.
Sumo Logic app for Elasticsearch uses metrics that are not scraped by the
elasticsearchreceiver
. The exact list of metrics needed is at the bottom of the post - most of these metrics are theindices
metrics.Additionally, some of the metrics need a
host
label.Describe the solution you'd like
New metrics should be added in the
metadata.yaml
file and have code for them generated. However, this will also require adding modification to theelasticsearchClient
interface, as some of the metrics are not being collected right now.Adding a
host
label can be resolved similarly as inmysqlreceiver
: #14340Describe alternatives you've considered
No response
Additional context
The missing metrics come from Telegraf plugin for Elasticsearch: link
Similar issues: #14095, #14138
List of needed metrics (disclaimer: I'm still verifying this list and some are already present):
Click to expand
The text was updated successfully, but these errors were encountered: