Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetrygen subcommand to generate OTLP log events #12927

Closed
spencergilbert opened this issue Aug 3, 2022 · 9 comments · Fixed by #18741
Closed

telemetrygen subcommand to generate OTLP log events #12927

spencergilbert opened this issue Aug 3, 2022 · 9 comments · Fixed by #18741
Assignees
@fatsheep9146
Labels
cmd/telemetrygen telemetrygen command data:logs Logs related issues enhancement New feature or request help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium

Comments

@spencergilbert
Copy link

Is your feature request related to a problem? Please describe.

Easily running integration tests for Vector's OTLP logs.

Describe the solution you'd like

The WIP telemetrygen currently has documented (WIP) support for traces and metrics, we should track in the implementation of logs as well.

Describe alternatives you've considered

Today I've just run the opentelemetry-collector to push logs with otlpexporter and otlphttpexporter.
@mx-psi mx-psi added help wanted Extra attention is needed data:logs Logs related issues cmd/telemetrygen telemetrygen command enhancement New feature or request labels Aug 3, 2022
@TylerHelmuth TylerHelmuth added the priority:p2 Medium label Aug 5, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@mx-psi mx-psi removed the Stale label Nov 10, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 10, 2023
@fatsheep9146 fatsheep9146 self-assigned this Jan 10, 2023
@fatsheep9146
Copy link
Contributor

fatsheep9146 commented Jan 10, 2023 •
edited
Loading

I'll help with this issue. @mx-psi

@mx-psi
Copy link
Member

mx-psi commented Jan 10, 2023

Thanks @fatsheep9146 🚀 let me know if I can help

@fatsheep9146
Copy link
Contributor

I think this issue is now blocked by #17898, since #17898 refract the code a lot. @mx-psi

@fatsheep9146 fatsheep9146 mentioned this issue Feb 7, 2023
Closed
@fatsheep9146 fatsheep9146 added the never stale Issues marked with this label will be never staled and automatically removed label Feb 7, 2023
@mx-psi
Copy link
Member

mx-psi commented Feb 8, 2023 •
edited
Loading

We could split part of #17898 into a refactor only PR if @atoulme is okay with it and this is blocking you

@fatsheep9146
Copy link
Contributor

We could split part of #17898 into a refactor only PR if @atoulme is okay with it and this is blocking you

I agree with that. @mx-psi @atoulme

@atoulme
Copy link
Contributor

atoulme commented Feb 8, 2023

Sure, sorry, this fell of my bucket list. I can cut a smaller PR to take care of refactoring.

@mx-psi
Copy link
Member

mx-psi commented Feb 15, 2023

@fatsheep9146 #17898 is merged, so this is now unblocked :)

@fatsheep9146 fatsheep9146 mentioned this issue Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fatsheep9146 fatsheep9146

Labels
cmd/telemetrygen telemetrygen command data:logs Logs related issues enhancement New feature or request help wanted Extra attention is needed never stale Issues marked with this label will be never staled and automatically removed priority:p2 Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pkg/telemetrygen] add support exporting log data fatsheep9146/opentelemetry-collector-contrib
5 participants
@atoulme @mx-psi @fatsheep9146 @spencergilbert @TylerHelmuth