Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tql::metrics::flags to the new flags API #12924

Closed
bogdandrutu opened this issue Aug 3, 2022 · 5 comments
Closed

Adapt tql::metrics::flags to the new flags API #12924

bogdandrutu opened this issue Aug 3, 2022 · 5 comments
Assignees

Comments

@bogdandrutu
Copy link
Member

No description provided.

@TylerHelmuth
Copy link
Member

Closing as PR is merged

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Aug 3, 2022

@TylerHelmuth what I implemented is a bit of a hack :) You need to probably to have "flags_no_record_value" func that works with bool. Later we can add other funcs when multiple flags are added.

@TylerHelmuth
Copy link
Member

TylerHelmuth commented Aug 3, 2022

Ah ok, I thought this issue was only tracking the switch to the new fields. I'll probably hold off removing the hack until Flags is completely removed and FlagsStruct is gets renamed to Flags

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 10, 2022
@TylerHelmuth TylerHelmuth added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels Nov 10, 2022
@TylerHelmuth TylerHelmuth removed the never stale Issues marked with this label will be never staled and automatically removed label Nov 21, 2022
@TylerHelmuth
Copy link
Member

Reviewing OTTL's use of flags today it looks like this issue can now be closed as we use Flags() during the GET (casted to int64) and SetFlags during the SET. Helper functions are no longer used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants