Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/resourcedetection] instance hostname missing on GKE with new detector #12354

Closed
mx-psi opened this issue Jul 13, 2022 · 0 comments · Fixed by #12355
Closed

[processor/resourcedetection] instance hostname missing on GKE with new detector #12354

mx-psi opened this issue Jul 13, 2022 · 0 comments · Fixed by #12355
Labels
bug Something isn't working comp:google Google Cloud components processor/resourcedetection Resource detection processor

Comments

@mx-psi
Copy link
Member

mx-psi commented Jul 13, 2022

Describe the bug

Before #10347, someone using the gke and gce detectors would have the instance hostname on GKE. After this change, the new gcp detector would not add this attribute. This is a regression on v0.55.0, and also makes it difficult for people to transition to the new detector.

Datadog needs this attribute in order to correctly correlate telemetry reported by the Collector with telemetry reported by the Datadog GCP integration, which uses this as part of the hostname.

Steps to reproduce

Add the gke and gce detectors to your Collector on a GKE cluster.

What did you expect to see?

The host.name attribute would be present as it happened on v0.54.0 and below

What did you see instead?

The host.name attribute is missing.

What version did you use?

v0.55.0

What config did you use?

receivers:
  hostmetrics:
    scrapers:
      load:
    collection_interval: 10s

processors:
  resourcedetection:
    detectors: [gke, gce]

exporters:
  logging:
    loglevel: debug

service:
  pipelines:
    metrics:
      receivers: [hostmetrics]
      processors: [resourcedetection]
      exporters: [logging]

Environment

v0.55.0 Docker image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp:google Google Cloud components processor/resourcedetection Resource detection processor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant