Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dissect feature to convert plain text to structured data #11533

Closed
newly12 opened this issue Jun 24, 2022 · 11 comments
Closed

support dissect feature to convert plain text to structured data #11533

newly12 opened this issue Jun 24, 2022 · 11 comments

Comments

@newly12
Copy link
Contributor

newly12 commented Jun 24, 2022

Is your feature request related to a problem? Please describe.
In elastic ecosystem, filebeat, logstash, elasticsearch all support dissect processor to convert plain text to structured data, which is pretty useful, given already exists filelogreceiver for log file ingestion, it seems to make sense to support this in otel collector as well.

Describe the solution you'd like
Support dissect processer.

Describe alternatives you've considered
Dissect operator in filelogreceiver

Additional context

@dmitryax
Copy link
Member

Hey @newly12 , what data you want to process with this? traces, metrics, logs or some attributes?

@dmitryax dmitryax added the priority:p3 Lowest label Jun 24, 2022
@newly12
Copy link
Contributor Author

newly12 commented Jun 25, 2022

@dmitryax in my use case, it's log line.

@dmitryax
Copy link
Member

@TylerHelmuth this is something that will be possible to do with transform processor, right?

@newly12
Copy link
Contributor Author

newly12 commented Sep 27, 2022

If we implement an in house processor that does dissect or something similar in a processor, a typical use case is that we want to parse the "log"(event) timestamp from a "dissected" field and set it as the log record's time, similar to what's currently in filelog receiver, the json_parser and then the timestamp operator. However currently time parsing can only be done by timestamp operator in this receiver, does it make sense to have this capability in a processor? would it be OTTL or a different processor? cc @linjunzhe

@newly12
Copy link
Contributor Author

newly12 commented Oct 10, 2022

If we implement an in house processor that does dissect or something similar in a processor, a typical use case is that we want to parse the "log"(event) timestamp from a "dissected" field and set it as the log record's time, similar to what's currently in filelog receiver, the json_parser and then the timestamp operator. However currently time parsing can only be done by timestamp operator in this receiver, does it make sense to have this capability in a processor? would it be OTTL or a different processor? cc @linjunzhe

Hi @TylerHelmuth any comment on this?

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Dec 12, 2022
@TylerHelmuth
Copy link
Member

IDK how I missed this for so long but thanks Stale Bot for the last ditch effort haha

I think this is definitely appropriate for the transformprocessor. There are some open issues for improving how OTTL/transformprocessor interact with time: #16067 and we just made a ParseJSON function.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions
Copy link
Contributor

Pinging code owners for pkg/ottl: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label May 12, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants