Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saphanareceiver] Some metric units don't follow Otel semantic conventions #10565

Closed
bertysentry opened this issue Jun 2, 2022 · 3 comments
Closed

Comments

@bertysentry
Copy link
Contributor

bertysentry commented Jun 2, 2022

Describe the bug
Some metrics don't follow Otel semantic conventions

Steps to reproduce
Nothing to reproduce. The problem lies in the specification of the receiver itself.

What did you expect to see?
Metrics should use brackets ({}) for units that count objects, and not 1 which is reserved for fractions and ratios:

  • saphana.license.limit ==> unit {licenses} (or empty)

What did you see instead?
Some metrics improperly use unit 1 which is reserved for fractions and ratios:

  • saphana.license.limit
  • saphana.license.peak

What version did you use?
Main branch

What config did you use?
N/A

Environment
N/A

Additional context
N/A

@bertysentry bertysentry added the bug Something isn't working label Jun 2, 2022
@djaglowski djaglowski added the priority:p3 Lowest label Jun 10, 2022
@github-actions
Copy link
Contributor

Pinging code owners: @dehaansa. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 30, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants