Skip to content

Commit

Permalink
[connector/exceptions] Add trace id and span id to generated logs (#2…
Browse files Browse the repository at this point in the history
…8670)

**Description:** <Describe what has changed.>
The current implementation generates logs from recorded exceptions in
spans, but is not possible to see which traces and spans generated those
logs. This PR adds that information to the logs

**Link to tracking Issue:** Fixes #24407
  • Loading branch information
marctc authored Nov 1, 2023
1 parent 7e06d30 commit fe06dee
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 6 deletions.
27 changes: 27 additions & 0 deletions .chloggen/exceptions-connector-add-span-trace-id.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: exceptionsconnector

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add trace id and span id to generated logs from exceptions when using exceptionsconnector.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [24407]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: []
2 changes: 2 additions & 0 deletions connector/exceptionsconnector/connector_logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ func (c *logsConnector) attrToLogRecord(sl plog.ScopeLogs, serviceName string, s
logRecord.SetTimestamp(event.Timestamp())
logRecord.SetSeverityNumber(plog.SeverityNumberError)
logRecord.SetSeverityText("ERROR")
logRecord.SetSpanID(span.SpanID())
logRecord.SetTraceID(span.TraceID())
eventAttrs := event.Attributes()
spanAttrs := span.Attributes()

Expand Down
12 changes: 6 additions & 6 deletions connector/exceptionsconnector/testdata/logs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ resourceLogs:
body: {}
severityNumber: 17
severityText: ERROR
spanId: ""
traceId: ""
spanId: 2a00000000000000
traceId: 2a000000000000000000000000000000
- attributes:
- key: span.kind
value:
Expand All @@ -48,8 +48,8 @@ resourceLogs:
body: {}
severityNumber: 17
severityText: ERROR
spanId: ""
traceId: ""
spanId: 2a00000000000000
traceId: 2a000000000000000000000000000000
scope: {}
- resource: {}
scopeLogs:
Expand All @@ -76,6 +76,6 @@ resourceLogs:
body: {}
severityNumber: 17
severityText: ERROR
spanId: ""
traceId: ""
spanId: 2a00000000000000
traceId: 2a000000000000000000000000000000
scope: {}

0 comments on commit fe06dee

Please sign in to comment.