Skip to content

Commit

Permalink
[processor/resourcedetectionprocessor] Bump OpenShift semconv from 1.…
Browse files Browse the repository at this point in the history
…16 to 1.18 (#19169)

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
  • Loading branch information
frzifus authored Mar 7, 2023
1 parent d1e86f4 commit e689856
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 3 deletions.
16 changes: 16 additions & 0 deletions .chloggen/resourcedetectionprocessor_openshift_bump_semconv.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: resourcedetectionprocessor

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Bump OpenShift semconv version from 1.16.0 to 1.18.0.

# One or more tracking issues related to the change
issues: [19168]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: Rename google openshift platform attribute from google_cloud_openshift to gcp_openshift.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import (

"go.opentelemetry.io/collector/pdata/pcommon"
"go.opentelemetry.io/collector/processor"
conventions "go.opentelemetry.io/collector/semconv/v1.16.0"
conventions "go.opentelemetry.io/collector/semconv/v1.18.0"
"go.uber.org/zap"

ocp "github.com/open-telemetry/opentelemetry-collector-contrib/internal/metadataproviders/openshift"
Expand Down Expand Up @@ -84,7 +84,7 @@ func (d *detector) Detect(ctx context.Context) (resource pcommon.Resource, schem
region = strings.ToLower(infra.Status.PlatformStatus.Azure.CloudName)
case "gcp":
provider = conventions.AttributeCloudProviderGCP
platform = conventions.AttributeCloudPlatformGoogleCloudOpenshift
platform = conventions.AttributeCloudPlatformGCPOpenshift
region = strings.ToLower(infra.Status.PlatformStatus.GCP.Region)
case "ibmcloud":
provider = conventions.AttributeCloudProviderIbmCloud
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

"github.com/stretchr/testify/assert"
"go.opentelemetry.io/collector/pdata/pcommon"
conventions "go.opentelemetry.io/collector/semconv/v1.16.0"
conventions "go.opentelemetry.io/collector/semconv/v1.18.0"
"go.uber.org/zap/zaptest"

ocp "github.com/open-telemetry/opentelemetry-collector-contrib/internal/metadataproviders/openshift"
Expand Down

0 comments on commit e689856

Please sign in to comment.