Skip to content

Commit

Permalink
[extension/jaegerremotesampling] remove misleading agent endpoint (#1…
Browse files Browse the repository at this point in the history
…8070)

* [extension/jaegerremotesampling] remove misleading agent endpoint

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

* Update .chloggen/remove_misleading_jaegerremotesampling_endpoint.yaml

---------

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
  • Loading branch information
frzifus authored Jan 28, 2023
1 parent f5d6f04 commit 650e624
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
16 changes: 16 additions & 0 deletions .chloggen/remove_misleading_jaegerremotesampling_endpoint.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: extension/jaegerremotesampling

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Remove misleading http endpoint from jaegerremotesampling extension.

# One or more tracking issues related to the change
issues: [18058]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
3 changes: 0 additions & 3 deletions extension/jaegerremotesampling/internal/http.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ func NewHTTP(telemetry component.TelemetrySettings, settings confighttp.HTTPServ
}

srv.mux = http.NewServeMux()
// the legacy endpoint
srv.mux.Handle("/", http.HandlerFunc(srv.samplingStrategyHandler))

// the new endpoint -- not strictly necessary, as the previous one would match it
// already, but good to have it explicit here
srv.mux.Handle("/sampling", http.HandlerFunc(srv.samplingStrategyHandler))
Expand Down
4 changes: 0 additions & 4 deletions extension/jaegerremotesampling/internal/http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ func TestEndpointsAreWired(t *testing.T) {
desc string
endpoint string
}{
{
desc: "legacy",
endpoint: "/",
},
{
desc: "new",
endpoint: "/sampling",
Expand Down

0 comments on commit 650e624

Please sign in to comment.