From 1b03346c9bce939742dfe9a3ef7ea9f819c932af Mon Sep 17 00:00:00 2001 From: Christos Markou Date: Mon, 16 Sep 2024 14:12:35 +0300 Subject: [PATCH] [processor/resourcedetection] Remove processor.resourcedetection.hostCPUModelAndFamilyAsString feature gate (#35203) Description: Follows #33077, https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/29152 and https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/29462. The feature gate has been stable since v0.101.0. Link to tracking Issue: Relates to https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/29025 and to https://github.com/open-telemetry/semantic-conventions/issues/495 /cc @mx-psi --------- Signed-off-by: ChrsMark --- .../remove_host_cpu_model_family_fg.yaml | 27 +++++++++++++++++++ .../internal/system/system.go | 8 ------ 2 files changed, 27 insertions(+), 8 deletions(-) create mode 100644 .chloggen/remove_host_cpu_model_family_fg.yaml diff --git a/.chloggen/remove_host_cpu_model_family_fg.yaml b/.chloggen/remove_host_cpu_model_family_fg.yaml new file mode 100644 index 000000000000..4c908c22df6c --- /dev/null +++ b/.chloggen/remove_host_cpu_model_family_fg.yaml @@ -0,0 +1,27 @@ +# Use this changelog template to create an entry for release notes. + +# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' +change_type: breaking + +# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver) +component: resourcedetectionprocessor + +# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). +note: Remove `processor.resourcedetection.hostCPUModelAndFamilyAsString` feature gate. + +# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. +issues: [29025] + +# (Optional) One or more lines of additional information to render under the primary note. +# These lines will be padded with 2 spaces and then inserted directly into the document. +# Use pipe (|) for multiline entries. +subtext: + +# If your change doesn't affect end users or the exported elements of any package, +# you should instead start your pull request title with [chore] or use the "Skip Changelog" label. +# Optional: The change log or logs in which this entry should be included. +# e.g. '[user]' or '[user, api]' +# Include 'user' if the change is relevant to end users. +# Include 'api' if there is a change to a library API. +# Default: '[user]' +change_logs: [] \ No newline at end of file diff --git a/processor/resourcedetectionprocessor/internal/system/system.go b/processor/resourcedetectionprocessor/internal/system/system.go index 45fc5c8607f2..9262ee914732 100644 --- a/processor/resourcedetectionprocessor/internal/system/system.go +++ b/processor/resourcedetectionprocessor/internal/system/system.go @@ -23,14 +23,6 @@ import ( ) var ( - _ = featuregate.GlobalRegistry().MustRegister( - "processor.resourcedetection.hostCPUModelAndFamilyAsString", - featuregate.StageStable, - featuregate.WithRegisterDescription("Change type of host.cpu.model.id and host.cpu.model.family to string."), - featuregate.WithRegisterFromVersion("v0.89.0"), - featuregate.WithRegisterToVersion("v0.101.0"), - featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/semantic-conventions/issues/495"), - ) _ = featuregate.GlobalRegistry().MustRegister( "processor.resourcedetection.hostCPUSteppingAsString", featuregate.StageStable,