Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinSdk code compatibility #73

Closed
LikeTheSalad opened this issue Sep 11, 2023 · 1 comment
Closed

MinSdk code compatibility #73

LikeTheSalad opened this issue Sep 11, 2023 · 1 comment

Comments

@LikeTheSalad
Copy link
Contributor

Currently, our minSdk is set to 21, however, our code can still use some 21+ APIs without any warnings since the instrumentation subproject's lint check is desugaring-aware.

Based on the above, I believe we should mention in the README that any consumer project with its minSdk set to lower than 26 must enable desugaring, otherwise their app could crash in devices with API level < 26.

I personally prefer to avoid relying on the corelib desugaring mechanism because it can increase the final APK size, however, since the corelib desugaring feature is a requirement from the opentelemetry-java lib as well, then avoiding to use 21+ code in this repo won't make any difference when it comes to having to enable corelib desugaring in the consumer project. Still, I wanted to provide visibility on this issue in order to give more detailed info on why corelib desugaring must be enabled and also to provide a place for comments/ideas on this topic.

@breedx-splk
Copy link
Contributor

I think that putting a notice about the desugaring requirement is very important. We have it in our docs as well, and users have been tripped up by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants