Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Repository maintenance on opentelemetry-go #2266

Closed
XSAM opened this issue Aug 8, 2024 · 8 comments
Closed

REQUEST: Repository maintenance on opentelemetry-go #2266

XSAM opened this issue Aug 8, 2024 · 8 comments
Assignees
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@XSAM
Copy link
Member

XSAM commented Aug 8, 2024

Affected Repository

https://github.com/open-telemetry/opentelemetry-go

Requested changes

Please grant access of https://github.com/organizations/open-telemetry/settings/actions/runner-groups/8 (Benchmark Bare Metal Runners) to this repository.

Related: open-telemetry/opentelemetry-go#4537

Purpose

Enable bare metal runners to run benchmarks.

Runner group name: 'Benchmark Bare Metal Runners'

Expected Duration

permanently

Repository Maintainers

  • @open-telemetry/go-maintainers
@XSAM XSAM added the area/repo-maintenance Maintenance of repos in the open-telemetry org label Aug 8, 2024
@XSAM XSAM changed the title REQUEST: Repository maintenance on opentelemetry-java REQUEST: Repository maintenance on opentelemetry-go Aug 8, 2024
@arminru arminru self-assigned this Aug 8, 2024
@arminru
Copy link
Member

arminru commented Aug 8, 2024

Done!

@arminru arminru closed this as completed Aug 8, 2024
XSAM added a commit to open-telemetry/opentelemetry-go that referenced this issue Aug 9, 2024
Part of #4537

These are some benchmark results from the `actuated` runner. It is
pretty clear to me that this runner does not have a stable environment
to produce stable benchmark results:
-
https://github.com/open-telemetry/opentelemetry-go/actions/runs/10278899889
-
https://github.com/open-telemetry/opentelemetry-go/actions/runs/10275384692

Thus, I am switching the runner to the self-hosted runner, which uses
bare metal, to run benchmarks.

This is the request to use this type of runner.
open-telemetry/community#2266

The underlying machine is m3.small.x86. It has 8 cores 64 GiB.
https://deploy.equinix.com/product/servers/m3-small/

---

This is an example of using this runner from otel java.
https://github.com/open-telemetry/opentelemetry-java/actions/runs/10277337397/job/28439208528

---

This runner cannot be triggered on a forked repo:
XSAM@faab7b9.
So, it is quite safe if we only let it run on the main branch.
@XSAM
Copy link
Member Author

XSAM commented Aug 9, 2024

@arminru This seems not to be working. Is there anything I missed?

https://github.com/open-telemetry/opentelemetry-go/actions/runs/10323960117

Requested labels: self-hosted
Job defined at: open-telemetry/opentelemetry-go/.github/workflows/benchmark.yml@refs/heads/main
Waiting for a runner to pick up this job...

@XSAM
Copy link
Member Author

XSAM commented Aug 10, 2024

A similar request to js: #1701

@trask
Copy link
Member

trask commented Aug 12, 2024

@arminru This seems not to be working. Is there anything I missed?

it looks like the bare metal runner is further restricted to specific workflows, I've added open-telemetry/opentelemetry-go/.github/workflows/benchmark.yml@refs/heads/main:

image

@trask
Copy link
Member

trask commented Aug 12, 2024

@XSAM I re-triggered the workflow, but looks like there's several jobs in front of it, so could take some time before we know if it worked:

image

@XSAM
Copy link
Member Author

XSAM commented Aug 13, 2024

@trask It works now. Thank you! https://github.com/open-telemetry/opentelemetry-go/actions/runs/10355848812

@arminru
Copy link
Member

arminru commented Aug 13, 2024

@trask Yes! Thanks, forgot about that part.

@tylerbenson
Copy link
Member

@arminru @trask going forward, I encourage you to instruct maintainers that jobs running on this runner should execute in less than 15 minutes, or be scheduled daily/weekly so as to avoid over utilization and resource starvation for other projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

4 participants