Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New teams docs-pt-approvers and docs-pt-maintainers #2232

Closed
2 tasks done
svrnm opened this issue Jul 22, 2024 · 15 comments
Closed
2 tasks done

New teams docs-pt-approvers and docs-pt-maintainers #2232

svrnm opened this issue Jul 22, 2024 · 15 comments
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org

Comments

@svrnm
Copy link
Member

svrnm commented Jul 22, 2024

Affected Repository

https://github.com/open-telemetry/opentelemetry.io

Requested changes

Note: We have individual contributors (like @edsoncelio, @EzzioMoreira), who helped making this happen. We are looking forward to have them go through the process of becoming established members and approvers eventually, following the membership guidelines

Purpose

Team to manage Portuguese translations for opentelemetry.io

Expected Duration

permanently

Repository Maintainers

@open-telemetry/docs-maintainers

@svrnm svrnm added the area/repo-maintenance Maintenance of repos in the open-telemetry org label Jul 22, 2024
@joaopgrassi
Copy link
Member

Feel free to also add me as an approver as a native pt-BR speaker :)

@emdneto
Copy link
Member

emdneto commented Jul 24, 2024

I'm more than glad to also help with as a native pt-BR speaker as well 🚀

@svrnm
Copy link
Member Author

svrnm commented Aug 1, 2024

Any updates? @open-telemetry/technical-committee @austinlparker @trask can someone take a look and create these teams for us? Thanks

@lmolkova
Copy link
Contributor

done
/cc @open-telemetry/docs-pt-approvers and @open-telemetry/docs-pt-maintainers

@trask
Copy link
Member

trask commented Aug 12, 2024

typically only members of docs-pt-maintainers would be team maintainers for docs-pt-approvers

@lmolkova
Copy link
Contributor

typically only members of docs-pt-maintainers would be team maintainers for docs-pt-approvers

👍
@svrnm was there a specific reason to have everyone in approvers be a maintainer?

@svrnm
Copy link
Member Author

svrnm commented Aug 13, 2024

typically only members of docs-pt-maintainers would be team maintainers for docs-pt-approvers

👍 @svrnm was there a specific reason to have everyone in approvers be a maintainer?

No, probably a copy and paste error on my end.

@lmolkova
Copy link
Contributor

fixed!

@chalin
Copy link
Contributor

chalin commented Aug 22, 2024

@trask
Copy link
Member

trask commented Aug 22, 2024

hey @chalin I think you need to give @open-telemetry/docs-pt-approvers write access to the repo first

@lmolkova
Copy link
Contributor

lmolkova commented Aug 22, 2024

hey @chalin I think you need to give @open-telemetry/docs-pt-approvers write access to the repo first

Thanks! Can confirm - I just did it and it works. I assume you also want to do it for @open-telemetry/docs-es-approvers

@chalin
Copy link
Contributor

chalin commented Aug 23, 2024

Thanks all!

Thanks! Can confirm - I just did it and it works.

Thanks all!

Btw, I thought that we were trying to avoid granting members or groups write access to repos, but if this is the way to go, so be it. /cc @svrnm

I assume you also want to do it for @open-telemetry/docs-es-approvers

Yes, for all localisation approvers, thanks.

@svrnm
Copy link
Member Author

svrnm commented Sep 4, 2024

Btw, I thought that we were trying to avoid granting members or groups write access to repos, but if this is the way to go, so be it. /cc @svrnm

That's why we have component-owners today, we do not need repo write permissions anymore. Maybe teams still need triage or read permissions for that?

@chalin
Copy link
Contributor

chalin commented Sep 4, 2024

Ok, so is there anything to be adjusted here -- e.g., write permission revoked for @open-telemetry/docs-XX-approvers etc.

@svrnm
Copy link
Member Author

svrnm commented Sep 5, 2024

Ok, so is there anything to be adjusted here -- e.g., write permission revoked for @open-telemetry/docs-XX-approvers etc.

Eventually, yes, it looks like we can lower permissions to "triage" for most teams that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/repo-maintenance Maintenance of repos in the open-telemetry org
Projects
None yet
Development

No branches or pull requests

6 participants