Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configure Clang on Windows #1480

Merged

Conversation

TsynkPavel
Copy link
Contributor

@TsynkPavel TsynkPavel commented Apr 3, 2023

Cmake condition was incorrectly set.
Instead of WIN32 (windows platform) was chosen MSVC (VS Compiler).
If build shared and static libraries there will be an error - multiple rules generate lib/jsoncpp.lib

@TsynkPavel TsynkPavel changed the title Fix compile Clang on Windows Fix configure Clang on Windows Apr 3, 2023
@baylesj baylesj merged commit 483f1c3 into open-source-parsers:master Sep 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants