Skip to content

Commit 0f107ef

Browse files
authored
Merge pull request #12 from oslabs-beta/alex/bug-component-info-render
Alex/bug component info render
2 parents 9ac0bb5 + 7504e54 commit 0f107ef

File tree

14 files changed

+77733
-35538
lines changed

14 files changed

+77733
-35538
lines changed

.env.example

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ SLACK_REDIRECT_URI = "REDIRECT URL HERE"
99

1010
# https://www.npmjs.com/package/dotenv
1111
# https://www.npmjs.com/package/quasar-dotenv
12-
# https://v1.quasar.dev/quasar-cli/handling-process-env
13-
# https://v1.quasar.dev/quasar-cli/quasar-conf-js#using-dotenv
12+
# https://v1.quasar.dev/quasar-cli/handling-process-env
13+
# https://v1.quasar.dev/quasar-cli/quasar-conf-js#using-dotenv

package-lock.json

Lines changed: 76318 additions & 34159 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

secretStuff/slackApiStuff.js

Lines changed: 0 additions & 7 deletions
This file was deleted.

src-electron/main-process/electron-main.dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* This file is used specifically and only for development. It installs
3-
* `electron-debug` & `vue-devtools`. There shouldn't be any need to
3+
* `electron-debug`. There shouldn't be any need to
44
* modify this file, but it can be used to extend your development
55
* environment.
66
*/

src-electron/main-process/electron-main.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,11 @@ For Sign In with Slack, but we are now using the Add to Slack feature instead
128128
// }
129129

130130
// Turns on event listener for Slack Oauth deep linking back app
131-
// TODO: Deep linking currently doesn't work properly in dev mode - requires fix
131+
// TODO: Deep linking currently doesn't work properly in dev mode on windows - requires fix
132132

133133
function setOauthListener() {
134-
logEverywhere(`process.env.SLACK_CLIENT_ID in electron-main: ${process.env.SLACK_CLIENT_ID}`);
135-
logEverywhere(`process.env.SLACK_CLIENT_SECRET in electron-main: ${process.env.SLACK_CLIENT_SECRET}`);
134+
// logEverywhere(`process.env.SLACK_CLIENT_ID in electron-main: ${process.env.SLACK_CLIENT_ID}`);
135+
// logEverywhere(`process.env.SLACK_CLIENT_SECRET in electron-main: ${process.env.SLACK_CLIENT_SECRET}`);
136136

137137
return deeplink.on("received", link => {
138138
logEverywhere(`auth worked here link: ${link}`);

src/App.vue

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ const ignoredActions = new Set([
1515
'setActiveComponent',
1616
'setActiveLayer',
1717
'upOneLayer',
18-
'setActiveHTML'
18+
'setActiveHTML',
19+
'updateComponentNameInputValue'
1920
])
2021
2122
let redoMixin = {

src/components/ComponentDisplay.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ export default {
225225
}
226226
},
227227
updated() {
228-
// if there are no active component, all boxes are unhighlighted
228+
// if there are no active components, all boxes are unhighlighted
229229
if (this.activeComponent === "") {
230230
if (this.$refs.boxes) {
231231
this.$refs.boxes.forEach(element => {
@@ -352,11 +352,13 @@ export default {
352352
353353
// unhighlights all inactive components
354354
onActivated(componentData) {
355+
console.log('onActivated - comp display, componentData', componentData)
355356
if (this.$refs.boxes) {
356357
this.$refs.boxes.forEach(element => {
357358
if (element.$attrs.id !== componentData.componentName) {
358359
element.enabled = false;
359360
element.$emit("deactivated");
361+
// this.setActiveComponent(componentData.componentName)
360362
element.$emit("update:active", false);
361363
}
362364
});
@@ -387,6 +389,7 @@ export default {
387389
388390
// user can change component's layer order
389391
handleLayer(e) {
392+
console.log('handeLayer\'s e: ', e)
390393
e.preventDefault();
391394
const payload = {
392395
activeComponent: this.activeComponent,

0 commit comments

Comments
 (0)