Skip to content

Update Zephyr CI tests to recent versions#2369

Merged
xuganyu96 merged 2 commits into
open-quantum-safe:mainfrom
Frauschi:patch-1
Mar 10, 2026
Merged

Update Zephyr CI tests to recent versions#2369
xuganyu96 merged 2 commits into
open-quantum-safe:mainfrom
Frauschi:patch-1

Conversation

@Frauschi
Copy link
Copy Markdown
Contributor

@Frauschi Frauschi commented Feb 25, 2026

Update the Zephyr RTOS versions covered in CI tests to versions 3.7.0 and 4.3.0.

Version 3.4.0 has been EOL for a long time (see here) and also causes some problems now (see #2361), version 3.7.0 is an LTS version. Version 4.3.0 is the latest version.

@Frauschi Frauschi force-pushed the patch-1 branch 2 times, most recently from a838875 to 56744ec Compare February 25, 2026 15:32
@Frauschi Frauschi mentioned this pull request Feb 25, 2026
2 tasks
@dstebila dstebila requested a review from bhess February 25, 2026 17:05
Copy link
Copy Markdown
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @Frauschi. The new 4.3.0 integration still seems to be failing in CI. Once that’s resolved, it looks good to me.

Comment thread .github/workflows/zephyr.yml
@Frauschi
Copy link
Copy Markdown
Contributor Author

Thanks for the update, @Frauschi. The new 4.3.0 integration still seems to be failing in CI. Once that’s resolved, it looks good to me.

The Zephyr tests now pass CI after some more fixes. Mainly, I had to remove the call to strdup() as Zephyr does not support that. I don't know why this hasn't caused problems up to now.

I don't know why these other CI tests fail now tbh.

@abhi-dev-engg
Copy link
Copy Markdown
Contributor

I don't know why these other CI tests fail now tbh.

#2366 (comment)

Copy link
Copy Markdown
Contributor

@xuganyu96 xuganyu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update on the Zephyr part of liboqs. Thank you so much!

My comments mostly revolve around explaining the specific technical choices, since I am not knowledgeable on Zephyr.

The CI failure was caused by some DNS problems with https://coveralls.io. I will re-run the pull request job.

Comment thread src/common/common.c
Comment thread zephyr/samples/KEMs/prj.conf
Comment thread .github/workflows/zephyr.yml Outdated
steps:
- name: Init Zephyr workspace
run: |
mkdir zephyr && cd zephyr
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nitpick: consider using mkdir -p zephyr/manifest for better clarity.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Only test the Version 3 LTS version (3.7) as well as the most recent
version (4.3). For the newest version, some changes to the samples
and the CI tests have been required.

Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 8, 2026

Coverage Status

coverage: 83.034% (+0.003%) from 83.031%
when pulling 18f1203 on Frauschi:patch-1
into 94662d9 on open-quantum-safe:main.

Copy link
Copy Markdown
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Frauschi

@Frauschi Frauschi requested a review from xuganyu96 March 9, 2026 10:14
Copy link
Copy Markdown
Contributor

@xuganyu96 xuganyu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the Zephyr test environment!

@xuganyu96 xuganyu96 merged commit 04ab195 into open-quantum-safe:main Mar 10, 2026
181 of 182 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants