Update Zephyr CI tests to recent versions#2369
Conversation
a838875 to
56744ec
Compare
cd4ce7a to
42c3016
Compare
The Zephyr tests now pass CI after some more fixes. Mainly, I had to remove the call to I don't know why these other CI tests fail now tbh. |
|
There was a problem hiding this comment.
Nice update on the Zephyr part of liboqs. Thank you so much!
My comments mostly revolve around explaining the specific technical choices, since I am not knowledgeable on Zephyr.
The CI failure was caused by some DNS problems with https://coveralls.io. I will re-run the pull request job.
| steps: | ||
| - name: Init Zephyr workspace | ||
| run: | | ||
| mkdir zephyr && cd zephyr |
There was a problem hiding this comment.
Very minor nitpick: consider using mkdir -p zephyr/manifest for better clarity.
Only test the Version 3 LTS version (3.7) as well as the most recent version (4.3). For the newest version, some changes to the samples and the CI tests have been required. Signed-off-by: Tobias Frauenschläger <t.frauenschlaeger@me.com>
xuganyu96
left a comment
There was a problem hiding this comment.
Thank you for updating the Zephyr test environment!
Update the Zephyr RTOS versions covered in CI tests to versions 3.7.0 and 4.3.0.
Version 3.4.0 has been EOL for a long time (see here) and also causes some problems now (see #2361), version 3.7.0 is an LTS version. Version 4.3.0 is the latest version.