Even less allocs #7190
Merged
Even less allocs #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**main** ``` BenchmarkLintAllEnabled-10 1 2640715625 ns/op 6385110200 B/op 116296633 allocs/op ``` **pr** ``` BenchmarkLintAllEnabled-10 1 2597179708 ns/op 6183614112 B/op 108421141 allocs/op ``` (I renamed the benchmark, but this is the same as "regal linting itself" used in the past) Another 8 million allocations cut off from `regal lint bundle`, and a whopping 10% improvements to wall clock time! The most significant improvement is the Equal implementation for refs, since that is called all over the place. But there are many other fixes here, and they all contribute something substantial (and fixes that only have had marginal impact have been left out). Signed-off-by: Anders Eknert <anders@styra.com>
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
srenatus
reviewed
Nov 24, 2024
| @@ -403,7 +406,8 @@ func (e *eval) evalStep(iter evalIterator) error { | |||
| }) | |||
| } | |||
| case *ast.Term: | |||
| rterm := e.generateVar(fmt.Sprintf("term_%d_%d", e.queryID, e.index)) | |||
| // generateVar inlined here to avoid extra allocations in hot path | |||
| rterm := ast.VarTerm(fmt.Sprintf("%s_term_%d_%d", e.genvarprefix, e.queryID, e.index)) | |||
There was a problem hiding this comment.
Interesting that the compiler couldn't inline that itself 🤔
There was a problem hiding this comment.
Not sure if it was possible for the compiler to inline, but it’s a little more elaborate, as our manual inlining also reduces 2 sprintf calls to one
srenatus
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main
pr
(I renamed the benchmark, but this is the same as "regal linting itself" used in the past)
Another 8 million allocations cut off from
regal lint bundle, and a whopping 10% improvements to wall clock time!The most significant improvement is the Equal implementation for refs, since that is called all over the place. But there are many other fixes here, and they all contribute something substantial (and fixes that only have had marginal impact have been left out).