Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove upgrade controller #3568

Open
anlandu opened this issue Sep 30, 2024 · 1 comment
Open

Remove upgrade controller #3568

anlandu opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@anlandu
Copy link
Member

anlandu commented Sep 30, 2024

Describe the solution you'd like
Now that the bug that rendered the upgrade controller necessary has been fixed, I think the upgrade controller can be safely removed (unless support for k8s <=1.13 is still required). Any thoughts on removing it? Have seen a few instances where customers are concerned thinking errors from this loop are causing impact. This is compounded by the fact that GET it does fetches not just v1alpha1 but all resources (due to the hub and spoke architecture), meaning that on every controller pod startup every GK resource is PUT again even if they're all stored properly as v1.

Environment:

  • Gatekeeper version: 3.17.1
  • Kubernetes version: (use kubectl version):
@anlandu anlandu added the enhancement New feature or request label Sep 30, 2024
@ritazh ritazh self-assigned this Oct 10, 2024
Copy link

stale bot commented Dec 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 11, 2024
@ritazh ritazh assigned JaydipGabani and unassigned ritazh Dec 11, 2024
@stale stale bot removed the stale label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants