v5.0.x: fcoll: move read_all functions to base #9939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all fcoll components (except individual) were using the same algorithm for read_all operations, derived originally from the dynamic component. To reduce the amount of code, move hence the read_all operation to fcoll/base. Signed-off-by: Edgar Gabriel <egabriel@central.uh.edu> (cherry picked from commit 1846e73)
Make base directories compile only the bare minimum when disabling ompio. These can make mca_ompio calls, which will lead to a linking error. Signed-off-by: Austen Lauria <awlauria@us.ibm.com> (cherry picked from commit cdd2067)
janjust
approved these changes
Jan 28, 2022
edgargabriel
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9928 and #9816 ports.