Fix --disable-ompio builds. #9928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make base directories compile only the bare minimum when disabling ompio. These can make mca_ompio calls, which will lead to a linking error. Signed-off-by: Austen Lauria <awlauria@us.ibm.com>
Contributor
Author
|
@edgargabriel I could have put this macro around only the offending calls, but went for the harder hammer approach to try and be a bit defensive. I'm open to either way. |
edgargabriel
approved these changes
Jan 26, 2022
Member
edgargabriel
left a comment
edgargabriel
left a comment
There was a problem hiding this comment.
I am conceptually fine with the solution, and I can confirm that if a user does not set the --disable-ompio option, ompio still builds correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make base directories compile only the bare minimum
when disabling ompio. These can make mca_ompio calls, which will
lead to a linking error.
Signed-off-by: Austen Lauria awlauria@us.ibm.com