LL/SC: be flexible with ret type #9900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use a temporary variable for holding the loaded value for ll/sc calls, eliminiating warnings about type mismatches for places where the compiler can implicitly cast into a register type anyway. This likely removes a slight bit of type safety, but also removes an ugly to fix warning about the use of typeof() on recent LLVM compilers that would be near impossible to fix and would hide all other warnings in noise. Given the relatively infrequent use of LL/SC and the ability to pay close attention when using it anyway, this is probably the more sane call. Signed-off-by: Brian Barrett <bbarrett@amazon.com>
Member
|
bot:ompi:retest |
bosilca
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use a temporary variable for holding the loaded value
for ll/sc calls, eliminiating warnings about type mismatches
for places where the compiler can implicitly cast into a
register type anyway. This likely removes a slight bit of
type safety, but also removes an ugly to fix warning about
the use of typeof() on recent LLVM compilers that would be
near impossible to fix and would hide all other warnings in
noise. Given the relatively infrequent use of LL/SC and the
ability to pay close attention when using it anyway, this is
probably the more sane call.
Signed-off-by: Brian Barrett bbarrett@amazon.com