Skip to content

v5.0.x: coll/ucc: fix int overflow in coll init #12821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sergei-Lebedev
Copy link
Contributor

@Sergei-Lebedev Sergei-Lebedev commented Sep 23, 2024

Fixing src/dst buffer size overflow. If scount or rcount are big enough result of multiplication of srount * comm_size or rcount * comm_size won't fit in int.

bot:notacherrypick

@github-actions github-actions bot added this to the v5.0.6 milestone Sep 23, 2024
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

e093c6e: coll/ucc: fix int overflow in coll init

  • check_signed_off: does not contain a valid Signed-off-by line
  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/coll_ucc_fix_buf_size_overflow_v5 branch from e093c6e to 0c20111 Compare September 23, 2024 13:48
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

0c20111: coll/ucc: fix int overflow in coll init

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@Sergei-Lebedev
Copy link
Contributor Author

bot:notacherrypick

Signed-off-by: Sergey Lebedev <sergeyle@nvidia.com>
bot:notacherrypick
@janjust janjust changed the title coll/ucc: fix int overflow in coll init coll/ucc: fix int overflow in coll init Sep 23, 2024
@Sergei-Lebedev Sergei-Lebedev force-pushed the topic/coll_ucc_fix_buf_size_overflow_v5 branch from 0c20111 to a2868ac Compare September 23, 2024 14:59
@janjust janjust changed the title coll/ucc: fix int overflow in coll init v5.0.x: coll/ucc: fix int overflow in coll init Sep 23, 2024
@janjust janjust merged commit 75795c0 into open-mpi:v5.0.x Sep 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants