-
Notifications
You must be signed in to change notification settings - Fork 902
11367 cherry picks to v5.0.x #11390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
awlauria
merged 14 commits into
open-mpi:v5.0.x
from
zerothi:11367-cherry-picks-to-v5.0.x
Feb 9, 2023
Merged
11367 cherry picks to v5.0.x #11390
awlauria
merged 14 commits into
open-mpi:v5.0.x
from
zerothi:11367-cherry-picks-to-v5.0.x
Feb 9, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Listified the elements and ensured links were properly set. Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit ed28457)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit b5eba4e)
Direct links to papers should preferably be done using DOI links. Publishers may (at will) change their URLs but they *will* obey doi.org/<doi> links meaning that links to published articles with DOI's will always be stable using: doi.org/<doi> links. I uncovered this link by doing make linkcheck which caused problems for the changed link (in feature/ulmf). Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit d5b9eb7)
Basically all files have had a go to be updated and beautified, too many to list here. Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 33869de)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 03d3e2e)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit cbc4601)
Also removed mentioning of some C++ bindings. It seemed weird to only have them in the *create_errhandler documents, hence removed. Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 87a5e09)
These changes also revealed some typos and we fixed lots of links and codes that were present. Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 23deccf)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 92049e6)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 8ea416c)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit 252f3be)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit cffffdd)
Signed-off-by: Nick Papior <nickpapior@gmail.com> (cherry picked from commit c5fdcc0)
At least one build environment has a Sphinx version that warns when we link directly to doi.org. Instead, it prefers that we use :doi: to link to DOI things. Signed-off-by: Jeff Squyres <jsquyres@cisco.com> (cherry picked from commit 3515978)
Can one of the admins verify this patch? |
ok to test |
jsquyres
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked #11367 + 3515978