Skip to content

v5.0.x: Add Missing MPI_F_XXX C constants #10530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 30, 2022
Merged

v5.0.x: Add Missing MPI_F_XXX C constants #10530

merged 2 commits into from
Jun 30, 2022

Conversation

drwootton
Copy link
Contributor

This is a cherry pick of #10491 to include MPI Fortran constants used by C code in mpi.in.h

Signed-off-by: David Wootton dwootton@us.ibm.com
(cherry picked from commit f27c1de)

Signed-off-by: David Wootton <dwootton@us.ibm.com>
(cherry picked from commit f27c1de)
@drwootton drwootton requested a review from jjhursey June 29, 2022 14:18
@drwootton drwootton self-assigned this Jun 29, 2022
@jjhursey jjhursey added this to the v5.0.0 milestone Jun 29, 2022
jjhursey
jjhursey previously approved these changes Jun 29, 2022
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the trailing whitespace on line 577 will be cleaned up in a later PR (related to PR #10528)

@jsquyres jsquyres changed the title Add Missing MPI_F_XXX C constants v5.0.x: Add Missing MPI_F_XXX C constants Jun 29, 2022
jsquyres
jsquyres previously approved these changes Jun 29, 2022
Add some clarifying comments, update some stale comments, and fix some
whitespace.

No code or logic changes.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
(cherry picked from commit d5f871d)
@jsquyres jsquyres dismissed stale reviews from jjhursey and themself June 29, 2022 15:34

Added another commit -- need Josh to re-review

@jsquyres
Copy link
Member

Hey @jjhursey -- I added the whitespace-/comment-fixing commit to this PR. Can you re-review?

@jsquyres jsquyres added the NEWS label Jun 29, 2022
hppritcha added a commit that referenced this pull request Jun 30, 2022
 v4.0.x: Add Missing MPI_F_XXX C constants #10530
jsquyres added a commit that referenced this pull request Jun 30, 2022
 v4.1.x: Add Missing MPI_F_XXX C constants #10530
@janjust janjust merged commit 3d432b9 into open-mpi:v5.0.x Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants