Skip to content

mpi.h.in: update several comments #10528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

jsquyres
Copy link
Member

Add some clarifying comments and update some stale comments.

No code or logic changes.

Signed-off-by: Jeff Squyres jsquyres@cisco.com

Copy link
Contributor

@drwootton drwootton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a couple nits but will approve anyway. If you think they are worthy of fixing then change them.

@jjhursey
Copy link
Member

@jsquyres Can you add this whitespace cleanup to this PR?

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One residual whitespace cleanup, then it is good to go.

Add some clarifying comments, update some stale comments, and fix some
whitespace.

No code or logic changes.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
@jsquyres jsquyres force-pushed the pr/some-mpih-comments branch from 236d964 to d5f871d Compare June 29, 2022 14:38
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsquyres jsquyres merged commit c47d78d into open-mpi:main Jun 29, 2022
@jsquyres jsquyres deleted the pr/some-mpih-comments branch June 29, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants