Warnings in master branch: src area

[rhc54]

Building CentOS with gcc 8.5.0 compiler:

src/mem/mpl_trmem.c:164:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
 static void init_classes()
             ^~~~~~~~~~~~
In file included from ./include/mpl.h:21,
                 from src/mem/mpl_trmem.c:15:
src/mem/mpl_trmem.c: In function ‘MPL_trvalid2’:
src/mem/mpl_trmem.c:649:18: warning: format ‘%p’ expects argument of type ‘void *’, but argument 4 has type ‘TRSPACE *’ {aka ‘struct TRSPACE *’} [-Wformat=]
                 ("[%d] Block at address %p is corrupted (invalid cookie in head)\n",
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                  world_rank, head + 1);
                              ~~~~~~~~
./include/mpl_msg.h:12:46: note: in definition of macro ‘MPL_error_printf’
 #define MPL_error_printf(...) fprintf(stderr,__VA_ARGS__)
                                              ^~~~~~~~~~~
src/mem/mpl_trmem.c: In function ‘MPL_strdup_no_spaces’:
src/mem/mpl_trmem.c:987:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
     for (int i = 0; i < strlen(str); i++) {

src/sock/mpl_sock.c: In function ‘MPL_large_writev’:
src/sock/mpl_sock.c:57:22: warning: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
         else if (tmp < iov[i].iov_len) {
                      ^
src/sock/mpl_sock.c: In function ‘MPL_large_readv’:
src/sock/mpl_sock.c:107:22: warning: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘size_t’ {aka ‘const long unsigned int’} [-Wsign-compare]
         else if (tmp < iov[i].iov_len) {
                      ^
src/str/mpl_argstr.c: In function ‘decode_buffer’:
src/str/mpl_argstr.c:73:32: warning: format ‘%X’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘int *’ [-Wformat=]
         if (0 == sscanf(hex, "%X", &value))
                               ~^   ~~~~~~
                               %X
src/gavl/mpl_gavl.c: In function ‘MPL_gavl_tree_delete_range’:
src/gavl/mpl_gavl.c:449:3: warning: label ‘fn_fail’ defined but not used [-Wunused-label]
   fn_fail:
   ^~~~~~~
src/gavl/mpl_gavl.c: In function ‘MPL_gavl_tree_delete_start_addr’:
src/gavl/mpl_gavl.c:474:3: warning: label ‘fn_fail’ defined but not used [-Wunused-label]
   fn_fail:
   ^~~~~~~
In file included from ./mpl/include/mpl_dbg.h:10,
                 from ./mpl/include/mpl_argstr.h:14,
                 from ./mpl/include/mpl.h:13,
                 from ./adio/include/adioi.h:1044,
                 from ./adio/include/adio.h:435,
                 from adio/common/ad_read_coll.c:6:

[awlauria]

These are coming from ROMIO, and will need to be addressed upstream, and pulled in via a romio update.

[wenduwan]

Need to re-evaluate compiler warnings. There have been many fixes since this issue was opened.

[wenduwan]

We haven't updated romio since this issue so I assume the problem still exists.