Don't pass immutable string to PMIx_Get_attribute_string taking char*

Signed-off-by: Joseph Schuchart <schuchart@icl.utk.edu>

Author: devreal

ompi/dpm/dpm.c

@@ -684,7 +684,10 @@ static int dpm_convert(opal_list_t *infos,
                if (0 != strncasecmp(ck, directive, strlen(directive))) {
                     opal_asprintf(&help_str, "Conflicting directives \"%s %s\"", ck, directive);
 #if PMIX_NUMERIC_VERSION >= 0x00040000
-                    attr = PMIx_Get_attribute_string(option);
+                    /* TODO: remove strdup if PMIx_Get_attribute_string takes const char* */
+                    char *option_dup = strdup(option);
+                    attr = PMIx_Get_attribute_string(option_dup);
+                    free(option_dup);
 #else
                     attr = option;
 #endif
@@ -715,8 +718,10 @@ static int dpm_convert(opal_list_t *infos,
                         /* we have a conflict */
                         opal_asprintf(&ptr, "  Option %s\n  Conflicting modifiers \"%s %s\"", option, infokey, modifier);
 #if PMIX_NUMERIC_VERSION >= 0x00040000
-                        /* TODO: this triggers a const warning :/ */
-                        attr = PMIx_Get_attribute_string(option);
+                        /* TODO: remove strdup if PMIx_Get_attribute_string takes const char* */
+                        char *option_dup = strdup(option);
+                        attr = PMIx_Get_attribute_string(option_dup);
+                        free(option_dup);
 #else
                         attr = option;
 #endif