Skip to content

Commit 3a42ee1

Browse files
committed
WIP: What to do about --with-verbs?
Do we still need --with-verbs any more? If so, its functionality should probably move to oshmem/mca/sshmem/verbs. If this functionality stays, OPAL_CHECK_OPENFABRICS should probably be renamed <something>_CHECK_VERBS. Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
1 parent e62ad09 commit 3a42ee1

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

config/opal_check_openfabrics.m4

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@
3434
AC_DEFUN([OPAL_CHECK_OPENFABRICS],[
3535
OPAL_VAR_SCOPE_PUSH([$1_msg])
3636

37+
# JMS Only oshmem/sshmem/verbs and hwloc uses any ibv_ functions.
38+
# JMS Do we still need much of this functionality?
39+
# JMS It feels like it should be moved under
40+
# oshmem/sshmem/mca/verbs/configure.m4, because that's the only place
41+
# left that calls OPAL_CHECK_OPENFABRICS.
42+
3743
# Setup the --with switches to allow users to specify where
3844
# verbs stuff lives.
3945
AC_REQUIRE([OPAL_CHECK_VERBS_DIR])

config/opal_check_verbs.m4

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ dnl
2424
dnl $HEADER$
2525
dnl
2626

27+
#
28+
# JMS If this functionality is still needed, it should be merged with
29+
# whatever happens to OPAL_CHECK_OPENFABRICS (e.g., move the whole
30+
# thing under oshmem/mca/sshmem/verbs).
31+
2732

2833
# Internal helper macro to look for the verbs libdir
2934
# --------------------------------------------------------

0 commit comments

Comments
 (0)