Silence pedantic compiler warnings. (#2580)

* Silence pedantic compiler warnings.

Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov>

* Address more pedantic compiler warnings.

Getting closer to successfully compiling with --enable-devel-check.

Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov>

* Add missing copyright.

Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov>

* Handle error path in pmix_query_strip_local_keys().

Signed-off-by: Samuel K. Gutierrez <samuel@lanl.gov>

Author: samuelkgutierrez

src/common/pmix_query.c

@@ -7,6 +7,7 @@
  * Copyright (c) 2019      Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
  * Copyright (c) 2021-2022 Nanook Consulting  All rights reserved.
+ * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -984,7 +985,7 @@ static pmix_query_t * pmix_query_strip_local_keys(pmix_query_t orig_queries[],
                                                   size_t orig_nqueries,
                                                   size_t nqueries)
 {
-    int rc;
+    int rc = PMIX_SUCCESS;
     size_t n, p, n_idx, p_idx;
     pmix_query_t *queries;
 
@@ -995,13 +996,20 @@ static pmix_query_t * pmix_query_strip_local_keys(pmix_query_t orig_queries[],
         for (p = 0; NULL != orig_queries[n].keys[p]; p++) {
             if (!pmix_query_check_is_local_resolve(orig_queries[n].keys[p])) {
                 PMIX_ARGV_APPEND(rc, queries[n_idx].keys, orig_queries[n].keys[p]);
+                if (PMIX_SUCCESS != rc) {
+                    goto out;
+                }
                 ++p_idx;
             }
         }
         if( p_idx > 0 ) {
             ++n_idx;
         }
     }
-
+out:
+    if (PMIX_SUCCESS != rc) {
+        PMIX_QUERY_RELEASE(queries);
+        // Note that queries is set to NULL by PMIX_QUERY_RELEASE.
+    }
     return queries;
 }

src/mca/bfrops/base/bfrop_base_print.c

@@ -13,7 +13,7 @@
  * Copyright (c) 2014-2020 Intel, Inc.  All rights reserved.
  * Copyright (c) 2016      Mellanox Technologies, Inc.
  *                         All rights reserved.
- *
+ * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * Copyright (c) 2021-2022 Nanook Consulting  All rights reserved.
  * $COPYRIGHT$
  *
@@ -47,7 +47,9 @@ char* PMIx_Info_string(pmix_info_t *info)
     PMIX_BFROPS_PRINT(rc, pmix_globals.mypeer,
                       &output, NULL,
                       (void*)info, PMIX_INFO);
-
+    if (PMIX_SUCCESS != rc) {
+        return NULL;
+    }
     return output;
 }
 
@@ -59,7 +61,9 @@ char* PMIx_Value_string(pmix_value_t *value)
     PMIX_BFROPS_PRINT(rc, pmix_globals.mypeer,
                       &output, NULL,
                       (void*)value, PMIX_VALUE);
-
+    if (PMIX_SUCCESS != rc) {
+        return NULL;
+    }
     return output;
 }
 
@@ -1604,7 +1608,7 @@ pmix_status_t pmix_bfrops_base_print_darray(char **output, char *prefix, pmix_da
                                             pmix_data_type_t type)
 {
     char *prefx, *tp, *tp2=NULL, *tp3;
-    pmix_status_t rc;
+    pmix_status_t rc = PMIX_ERR_BAD_PARAM;
     size_t n;
     bool *bptr;
     uint8_t *u8ptr;

src/mca/gds/hash/gds_hash.c

@@ -5,7 +5,7 @@
  *                         and Technology (RIST).  All rights reserved.
  * Copyright (c) 2018-2020 Mellanox Technologies, Inc.
  *                         All rights reserved.
- *
+ * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * Copyright (c) 2021-2022 Nanook Consulting.  All rights reserved.
  * $COPYRIGHT$
  *
@@ -146,7 +146,7 @@ static pmix_status_t hash_cache_job_info(struct pmix_namespace_t *ns, pmix_info_
     pmix_job_t *trk;
     pmix_session_t *s = NULL, *sptr;
     pmix_hash_table_t *ht;
-    pmix_kval_t *kp2, *kvptr, kv;
+    pmix_kval_t *kp2 = NULL, *kvptr, kv;
     pmix_value_t val;
     pmix_info_t *iptr;
     char **nodes = NULL, **procs = NULL;

src/server/pmix_server_ops.c

@@ -9,6 +9,7 @@
  *                         All rights reserved.
  * Copyright (c) 2016-2020 IBM Corporation.  All rights reserved.
  * Copyright (c) 2021-2022 Nanook Consulting.  All rights reserved.
+ * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -3983,7 +3984,7 @@ pmix_status_t pmix_server_grpconstruct(pmix_server_caddy_t *cd, pmix_buffer_t *b
     bool barrier_directive_included = false;
     pmix_buffer_t bucket;
     pmix_byte_object_t bo;
-    pmix_grpinfo_t *g;
+    pmix_grpinfo_t *g = NULL;
     pmix_kval_t *kv;
 
     pmix_output_verbose(2, pmix_server_globals.connect_output,

src/util/pmix_hash.c

@@ -13,6 +13,7 @@
  *                         All rights reserved.
  * Copyright (c) 2016      IBM Corporation.  All rights reserved.
  * Copyright (c) 2021-2022 Nanook Consulting  All rights reserved.
+ * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
  * Additional copyrights may follow
@@ -110,7 +111,7 @@ pmix_status_t pmix_hash_store(pmix_hash_table_t *table,
     pmix_status_t rc;
     pmix_data_array_t *darray;
     pmix_qual_t *qarray;
-    size_t n, m;
+    size_t n, m = 0;
 
     pmix_output_verbose(10, pmix_globals.debug_output,
                         "HASH:STORE:QUAL rank %s key %s",