Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add codespell pre-commit hook and fix typos #920

Merged
merged 15 commits into from
Oct 13, 2021

Conversation

Junjun2016
Copy link
Collaborator

Motivation

Refers to open-mmlab/mmdetection#6099, this hook can check all typos in the code, it can help us to avoid typos.

Modification

As the title.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
It may break CI if new PRs have typos.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #920 (54a89a8) into master (d4d64eb) will decrease coverage by 0.04%.
The diff coverage is 62.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage   89.90%   89.85%   -0.05%     
==========================================
  Files         117      118       +1     
  Lines        6555     6558       +3     
  Branches     1019     1019              
==========================================
  Hits         5893     5893              
- Misses        461      464       +3     
  Partials      201      201              
Flag Coverage Δ
unittests 89.85% <62.24%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/core/evaluation/metrics.py 90.42% <ø> (ø)
mmseg/datasets/pipelines/formating.py 0.00% <0.00%> (-63.83%) ⬇️
mmseg/models/backbones/bisenetv2.py 99.28% <ø> (ø)
mmseg/models/backbones/mit.py 91.33% <ø> (ø)
mmseg/models/backbones/vit.py 87.11% <ø> (ø)
mmseg/models/decode_heads/dpt_head.py 96.15% <ø> (ø)
mmseg/models/losses/utils.py 81.57% <ø> (ø)
mmseg/models/utils/shape_convert.py 100.00% <ø> (ø)
mmseg/datasets/pipelines/formatting.py 63.82% <63.82%> (ø)
mmseg/datasets/pipelines/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d64eb...54a89a8. Read the comment docs.

@@ -48,9 +48,9 @@
},
"outputs": [],
"source": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may ignore .ipynb.

@xvjiarui xvjiarui merged commit 54bd4bd into open-mmlab:master Oct 13, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
…#920)

* add codespell pre-commit hook and fix typos

* Update mmseg/models/decode_heads/dpt_head.py

* Update mmseg/models/backbones/vit.py

* Update mmseg/models/backbones/vit.py

* fix typos

* skip formating typo

* deprecate formating

* skip ipynb

* unstage ipynb changes

* unstage ipynb changes

* fix typos in ipynb

* unstage ipynb changes
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this pull request Dec 3, 2023
* add cfg

* add cfg

* update configs

* add ochuman benchmark

* update format
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants