fix bug about label_map #1445
Merged
fix bug about label_map #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MeowZheng
approved these changes
Apr 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
- Coverage 90.34% 90.31% -0.04%
==========================================
Files 139 139
Lines 8300 8304 +4
Branches 1393 1395 +2
==========================================
+ Hits 7499 7500 +1
- Misses 564 567 +3
Partials 237 237
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
MengzhangLI
reviewed
Apr 5, 2022
Co-authored-by: MengzhangLI <mcmong@pku.edu.cn>
|
might fix lint problem |
MengzhangLI
approved these changes
Apr 6, 2022
There is the same bug in core/evaluation/metrics.py when calculating IoU. |
mob5566
pushed a commit
to mob5566/mmsegmentation
that referenced
this pull request
Apr 13, 2022
* fix bug about label_map * Update mmseg/datasets/pipelines/loading.py Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> * lint Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> Co-authored-by: MeowZheng <meowzheng@outlook.com>
ZhimingNJ
pushed a commit
to AetrexTechnology/mmsegmentation
that referenced
this pull request
Jun 29, 2022
* fix bug about label_map * Update mmseg/datasets/pipelines/loading.py Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> * lint Co-authored-by: MengzhangLI <mcmong@pku.edu.cn> Co-authored-by: MeowZheng <meowzheng@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I use label_map to change train_label, I found that when the label map is complex, the current code is likely to repeatedly replace gt_semantic_seg.
For example, when my label_map is dict{6:9, 9:7}, the intention is to replace 6 with 9 and 9 with 7, but the result does replace 6 with 7.
Modification
Record the initial gt_semantic_seg with a copy!