Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add with cp to mit and vit #1431

Merged
merged 3 commits into from
Apr 1, 2022

Conversation

jiangyitong
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support with cp for mit and vit backbone

Modification

add with_cp parameter and modify the transformerencoder

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #1431 (42a9093) into master (30864ea) will increase coverage by 0.12%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   90.22%   90.34%   +0.12%     
==========================================
  Files         136      139       +3     
  Lines        7946     8300     +354     
  Branches     1323     1393      +70     
==========================================
+ Hits         7169     7499     +330     
- Misses        552      564      +12     
- Partials      225      237      +12     
Flag Coverage Δ
unittests 90.34% <92.85%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/models/backbones/mit.py 86.98% <80.00%> (-0.70%) ⬇️
mmseg/core/layer_decay_optimizer_constructor.py 88.37% <88.37%> (ø)
mmseg/models/backbones/beit.py 92.33% <92.33%> (ø)
mmseg/core/__init__.py 100.00% <100.00%> (ø)
mmseg/models/backbones/__init__.py 100.00% <100.00%> (ø)
mmseg/models/backbones/vit.py 90.58% <100.00%> (+0.40%) ⬆️
mmseg/models/losses/cross_entropy_loss.py 82.71% <100.00%> (+3.30%) ⬆️
mmseg/models/losses/utils.py 87.50% <100.00%> (+5.92%) ⬆️
mmseg/models/necks/__init__.py 100.00% <100.00%> (ø)
mmseg/models/necks/featurepyramid.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a6c39...42a9093. Read the comment docs.

@Junjun2016
Copy link
Collaborator

@jiangyitong
Please sign the CLA.

@Junjun2016 Junjun2016 changed the title add with cp to mit and vit [Feature] add with cp to mit and vit Apr 1, 2022
@Junjun2016 Junjun2016 changed the title [Feature] add with cp to mit and vit [Feature] Add with cp to mit and vit Apr 1, 2022
@MengzhangLI
Copy link
Contributor

Look Good To Me.

I would make channel number, width and height of input and weight of model smaller in unit test to pass CI more quickly in the other pr.

@MeowZheng MeowZheng merged commit be8f073 into open-mmlab:master Apr 1, 2022
mob5566 pushed a commit to mob5566/mmsegmentation that referenced this pull request Apr 13, 2022
* add with cp to mit and vit

* add test unit

Co-authored-by: jiangyitong <jiangyitong1@sensetime.com>
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
* add with cp to mit and vit

* add test unit

Co-authored-by: jiangyitong <jiangyitong1@sensetime.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants