-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] add XFUND dataset and project LayoutLMv3 #1809
base: dev-1.x
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ see 97 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
…v3ImageProcessor实现数值对齐
good job~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a great project! It can be merged as two comments are resolved
@@ -186,8 +186,7 @@ def move(self, mapping: List[Tuple[str, str]]) -> None: | |||
if '*' in src: | |||
mkdir_or_exist(dst) | |||
for f in glob.glob(src): | |||
if not osp.exists( | |||
osp.join(dst, osp.relpath(f, self.data_root))): | |||
if not osp.exists(osp.join(dst, osp.basename(f))): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modification may break other dataset preparers. Need to make the if condition compatible with both cases.
projects/LayoutLMv3/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A readme is very important to tell others how to run your project, you can spend some time writing it
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
1.增加xfund SER/RE任务的数据集:支持生成MMOCR形式的SER、RE任务标注文件(以.json结尾)
2.新增LayoutLMv3 project.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: