[Fix] BaseModel & BaseDataPreprocessor to
method to be consistent with torch.nn.Module
#783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Make
BaseModel.to
andBaseDataPreprocessor.to
methods to be consistent withtorch.nn.Module.to
, i.e. it can accept devices and dtypes as arguments and handle these cases properly.Before this PR:
After this PR:
Modification
As in PR
BC-breaking (Optional)
Probably, because before this PR
dtype
kwargs are ignoredUse cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist