-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Deprecate _save_to_state_dict implemented in mmengine #610
[Enhancement] Deprecate _save_to_state_dict implemented in mmengine #610
Conversation
get_state_dict
directly call nn.Module._save_to_state_dict
rather than mmengine.runner.checkpoint._save_to_state_dict
.
Should we remove |
Codecov ReportBase: 78.45% // Head: 78.43% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
- Coverage 78.45% 78.43% -0.03%
==========================================
Files 126 126
Lines 9141 9141
Branches 1818 1818
==========================================
- Hits 7172 7170 -2
- Misses 1656 1660 +4
+ Partials 313 311 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Suggest updating the PR message to describe that some downstream repos need to override this method to custom how to save checkpoints. |
get_state_dict
directly call nn.Module._save_to_state_dict
rather than mmengine.runner.checkpoint._save_to_state_dict
.Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
…pen-mmlab#610) * [Refine] Make get_state_dict directly call nn.Module._save_to_state_dict * deprecate _save_to_state_dict * deprecate _save_to_state_dict in 0.5.0 * deprecate in 0.3.0 Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com> Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Make get_state_dict directly call
nn.Module._save_to_state_dict
. Since #542 has been merged, there is no different betweennn.Module._save_to_state_dict
andmmengine.runner.checkpoint._save_to_state_dict
.After merging this PR, downstream repos can override
._save_to_state_dict
to customize how to save checkpointModification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist