Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project/Centernet2 #9566

Open
wants to merge 6 commits into
base: dev-3.x
Choose a base branch
from
Open

Project/Centernet2 #9566

wants to merge 6 commits into from

Conversation

zytx121
Copy link
Collaborator

@zytx121 zytx121 commented Jan 4, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@zytx121 zytx121 added the WIP Working in progress label Jan 4, 2023
return pos_loss + neg_loss

@MODELS.register_module()
class CustomGaussianFocalLoss(nn.Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we directly use the GaussianFocalLoss implemented in MMDet for CornerNet?

Copy link
Collaborator Author

@zytx121 zytx121 Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CN2's GaussianFocalLoss should support ignore_high_fp, so we cannot directly use the GaussianFocalLoss implemented in MMDet.
https://github.com/xingyizhou/CenterNet2/blob/8745e012e4dbdf560ac2f27e0b771d4907ad4aaf/centernet/modeling/layers/heatmap_focal_loss.py#L34

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add a brief description

@ZwwWayne ZwwWayne added this to the 3.0.0rc6 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Working in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants