Fix issue with list of metrics in CustomDataset.evaluate #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: modified: mmdet/datasets/custom.py
hellock
reviewed
Feb 21, 2020
mmdet/datasets/custom.py
Outdated
| @@ -178,12 +178,14 @@ def evaluate(self, | |||
| scale_ranges (list[tuple] | None): Scale ranges for evaluating mAP. | |||
| Default: None. | |||
| """ | |||
| metrics = metric if isinstance(metric, list) else [metric] | |||
There was a problem hiding this comment.
Thanks for the fix! Since "mAP" and "recall" cannot be evaluated at the same time, we may simply cast metric to a str like in voc dataset.
if not isinstance(metric, str):
assert len(metric) == 1
metric = metric[0]There was a problem hiding this comment.
Thank you! I did not immediately realized that recall and mAP accept different parameters. I will make changes and resubmit.
Changes to be committed: modified: mmdet/datasets/custom.py
hellock
approved these changes
Feb 22, 2020
mattdawkins
added a commit
to VIAME/mmdetection
that referenced
this pull request
Feb 26, 2020
* jon/dev/fix_fpn2: (33 commits) Fix FPN upscale fix analyze log (open-mmlab#2150) Fix a documentation error in GETTING_STARTED.md (open-mmlab#2149) add optimizer registry (open-mmlab#2139) Update version to 1.1 (open-mmlab#2144) Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135) reset worker_seed (open-mmlab#2111) Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128) Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583) fixed test package (open-mmlab#2127) add an argument format-only to handle the json formating (open-mmlab#2114) fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116) fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099) fix workflow problem (open-mmlab#2103) Uint8 fix (open-mmlab#2105) Fix device bug (open-mmlab#2098) fix test ddp initialize (open-mmlab#2100) set FORCE_CUDA (open-mmlab#2097) Speed up sampler (open-mmlab#2094) Use official DDP to implement MMDDP (open-mmlab#2090) ...
mattdawkins
added a commit
to VIAME/mmdetection
that referenced
this pull request
Mar 13, 2020
* tag 'v1.1.0': (29 commits) Update version to 1.1 (open-mmlab#2144) Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135) reset worker_seed (open-mmlab#2111) Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128) Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583) fixed test package (open-mmlab#2127) add an argument format-only to handle the json formating (open-mmlab#2114) fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116) fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099) fix workflow problem (open-mmlab#2103) Uint8 fix (open-mmlab#2105) Fix device bug (open-mmlab#2098) fix test ddp initialize (open-mmlab#2100) set FORCE_CUDA (open-mmlab#2097) Speed up sampler (open-mmlab#2094) Use official DDP to implement MMDDP (open-mmlab#2090) log meta (open-mmlab#2086) fix pad_val not used in class Pad when pad to a fixed size (open-mmlab#2093) remove cython docs (open-mmlab#2091) remove new_tensor (open-mmlab#2092) ...
ioir123ju
pushed a commit
to ioir123ju/mmdetection
that referenced
this pull request
Mar 30, 2020
…2128) * Fix issue with list of metrics in CustomDataset.evaluate Changes to be committed: modified: mmdet/datasets/custom.py * Updated to evaluate only one of mAP or recall Changes to be committed: modified: mmdet/datasets/custom.py
mike112223
pushed a commit
to mike112223/mmdetection
that referenced
this pull request
Aug 25, 2020
…2128) * Fix issue with list of metrics in CustomDataset.evaluate Changes to be committed: modified: mmdet/datasets/custom.py * Updated to evaluate only one of mAP or recall Changes to be committed: modified: mmdet/datasets/custom.py
jben-hun
pushed a commit
to jben-hun/mmdetection
that referenced
this pull request
Jan 10, 2025
…2128) * Fix issue with list of metrics in CustomDataset.evaluate Changes to be committed: modified: mmdet/datasets/custom.py * Updated to evaluate only one of mAP or recall Changes to be committed: modified: mmdet/datasets/custom.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: mmdet/datasets/custom.py