Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflow problem #2103

Merged
merged 3 commits into from
Feb 17, 2020
Merged

fix workflow problem #2103

merged 3 commits into from
Feb 17, 2020

Conversation

abcxs
Copy link
Contributor

@abcxs abcxs commented Feb 16, 2020

When use workflow [(train, 1), (val, 1)], cfg.data.val will use test_pipeline, it will raise a error. So we change the pipeline manually.

@hellock
Copy link
Member

hellock commented Feb 16, 2020

Thanks! Could you fix the linting error?

@abcxs abcxs requested a review from hellock February 16, 2020 14:46
hellock
hellock reviewed Feb 17, 2020
View reviewed changes
tools/train.py Outdated
@@ -115,7 +116,9 @@ def main():

datasets = [build_dataset(cfg.data.train)]
if len(cfg.workflow) == 2:
datasets.append(build_dataset(cfg.data.val))
val_dataset = copy.deepcopy(cfg.data.val)
val_dataset.pipeline = cfg.train_pipeline
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change cfg.train_pipeline to cfg.data.train.pipeline since cfg.train_pipeline may not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@hellock hellock merged commit 923b70a into open-mmlab:master Feb 17, 2020
@abcxs abcxs deleted the test branch February 17, 2020 04:34
mattdawkins added a commit to VIAME/mmdetection that referenced this pull request Feb 26, 2020
@mattdawkins
Merge remote-tracking branch 'jon/dev/fix_fpn2' into viame/master
6ba17cd 
* jon/dev/fix_fpn2: (33 commits)
  Fix FPN upscale
  fix analyze log (open-mmlab#2150)
  Fix a documentation error in GETTING_STARTED.md (open-mmlab#2149)
  add optimizer registry (open-mmlab#2139)
  Update version to 1.1 (open-mmlab#2144)
  Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135)
  reset worker_seed (open-mmlab#2111)
  Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128)
  Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583)
  fixed test package (open-mmlab#2127)
  add an argument format-only to handle the json formating (open-mmlab#2114)
  fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116)
  fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099)
  fix workflow problem (open-mmlab#2103)
  Uint8 fix (open-mmlab#2105)
  Fix device bug (open-mmlab#2098)
  fix test ddp initialize (open-mmlab#2100)
  set FORCE_CUDA (open-mmlab#2097)
  Speed up sampler (open-mmlab#2094)
  Use official DDP to implement MMDDP (open-mmlab#2090)
  ...
mattdawkins added a commit to VIAME/mmdetection that referenced this pull request Mar 13, 2020
@mattdawkins
Merge tag 'v1.1.0' into HEAD
04edba8 
* tag 'v1.1.0': (29 commits)
  Update version to 1.1 (open-mmlab#2144)
  Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135)
  reset worker_seed (open-mmlab#2111)
  Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128)
  Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583)
  fixed test package (open-mmlab#2127)
  add an argument format-only to handle the json formating (open-mmlab#2114)
  fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116)
  fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099)
  fix workflow problem (open-mmlab#2103)
  Uint8 fix (open-mmlab#2105)
  Fix device bug (open-mmlab#2098)
  fix test ddp initialize (open-mmlab#2100)
  set FORCE_CUDA (open-mmlab#2097)
  Speed up sampler (open-mmlab#2094)
  Use official DDP to implement MMDDP (open-mmlab#2090)
  log meta (open-mmlab#2086)
  fix pad_val not used in class Pad when pad to a fixed size (open-mmlab#2093)
  remove cython docs (open-mmlab#2091)
  remove new_tensor (open-mmlab#2092)
  ...
ioir123ju pushed a commit to ioir123ju/mmdetection that referenced this pull request Mar 30, 2020
@abcxs @ioir123ju
fix workflow problem (open-mmlab#2103)
e6a4500 
* fix workflow problem

* import sort

* update pipeline
mike112223 pushed a commit to mike112223/mmdetection that referenced this pull request Aug 25, 2020
@abcxs
fix workflow problem (open-mmlab#2103)
3ce959b 
* fix workflow problem

* import sort

* update pipeline
@OpenMMLab-Assistant-004
Copy link

Hi @abcxs ！First of all, we want to express our gratitude for your significant PR in the mmdetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

1 similar comment
@OpenMMLab-Assistant-004
Copy link

Hi @abcxs ！First of all, we want to express our gratitude for your significant PR in the mmdetection project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

jben-hun pushed a commit to jben-hun/mmdetection that referenced this pull request Jan 10, 2025
@abcxs
fix workflow problem (open-mmlab#2103)
1923b06 
* fix workflow problem

* import sort

* update pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellock hellock hellock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abcxs @hellock @OpenMMLab-Assistant-004