Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ext ops, support parrots #310

Merged
merged 27 commits into from
Jun 28, 2020
Merged

add ext ops, support parrots #310

merged 27 commits into from
Jun 28, 2020

Conversation

zhuyuanhao
Copy link
Contributor

  1. add ext ops from mmdection, update some ops according to torchvision and detection2.
  2. add support for sensetime's parrots deep learning framework.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2020

CLA assistant check
All committers have signed the CLA.

group_size = ctx.group_size
scale_factor = ctx.scale_factor

if torch.__version__ == 'parrots':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parrots 0.6.1的zeros_like已经支持了requires_grad,可以试一下

@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #310 into master will decrease coverage by 18.30%.
The diff coverage is 0.12%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #310       +/-   ##
===========================================
- Coverage   71.63%   53.33%   -18.31%     
===========================================
  Files          94      118       +24     
  Lines        4739     6366     +1627     
  Branches      931     1084      +153     
===========================================
  Hits         3395     3395               
- Misses       1168     2795     +1627     
  Partials      176      176               
Flag Coverage Δ
#unittests 53.33% <0.12%> (-18.31%) ⬇️
Impacted Files Coverage Δ
mmcv/__init__.py 100.00% <ø> (ø)
mmcv/ops/__init__.py 0.00% <0.00%> (ø)
mmcv/ops/bbox.py 0.00% <0.00%> (ø)
mmcv/ops/carafe.py 0.00% <0.00%> (ø)
mmcv/ops/cc_attention.py 0.00% <0.00%> (ø)
mmcv/ops/context_block.py 0.00% <0.00%> (ø)
mmcv/ops/conv_ws.py 0.00% <0.00%> (ø)
mmcv/ops/corner_pool.py 0.00% <0.00%> (ø)
mmcv/ops/deform_conv.py 0.00% <0.00%> (ø)
mmcv/ops/deform_roi_pool.py 0.00% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7bf770...d3629b9. Read the comment docs.

None, None, None, None


class SyncBatchNorm(Module):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may register it as MMSyncBN.

@hellock hellock merged commit c0f5492 into open-mmlab:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants