fix dependencies #146

DXist · 2019-10-30T17:20:47Z

This PR changes install_requires.

Dependency on opencv-python is resolved in the same way as done in albumentations https://github.com/albu/albumentations/blob/master/setup.py#L12) library. opencv-python is used if it has already been installed. Otherwise opencv-python-headless is used which is good for minimal container environments.
Cython is build-time dependency and is removed from install_requires

codecov · 2019-10-30T17:25:26Z

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #146   +/-   ##
======================================
  Coverage    39.5%   39.5%           
======================================
  Files          67      67           
  Lines        2724    2724           
======================================
  Hits         1076    1076           
  Misses       1648    1648

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8829ff0...5705b06. Read the comment docs.

hellock · 2019-11-09T16:53:46Z

setup.py


 dist.Distribution().fetch_build_eggs(['Cython', 'numpy>=1.11.1'])

 import numpy  # noqa: E402
 from Cython.Distutils import build_ext  # noqa: E402

+
+def choose_requirement(main, secondary):
+    """If some version version of main requirement installed, return main,


A minor typo here: version version.

hellock · 2019-11-09T16:55:57Z

setup.py

 ]
+# If first not installed install second package
+CHOOSE_INSTALL_REQUIRES = [('opencv-python>=4.1.1',


We may relax the version requirement for opencv. OpenCV 3 & 4 should both work well.

hellock · 2019-11-09T16:57:17Z

Thanks for the fix!

hellock · 2019-11-17T09:09:57Z

Hi @DXist, I changed the priority of opencv-python and opencv-python-headless.
MMCV provides lots of visualization methods, which requires the GUI support by default. If we install opencv-python-headless by default, there will be errors raised in new environments.
To guide the users who meet issues related to the dependency, I add some comments in the readme.
Is it ok to you?

DXist · 2019-11-17T13:42:51Z

Hi @hellock . It's ok for me but there would be inconsistency with albumentations order that is used by mmdetection.

If mmdetection and mmcv are installed by a single pip install command then both opencv-python and opencv-python-headless will be installed, one of them will overwrite another one.

hellock · 2019-11-18T10:48:20Z

I see, so the installation guide in mmdetection should be the following to avoid installing both opencv-python and opencv-python-headless.

pip install mmcv
# git clone #
pip install -e .

If users would like to switch to opencv-python-headless, then it should be installed first.

DXist · 2019-11-18T17:14:26Z

@hellock sounds reasonable

GiscardBiamby · 2019-12-20T23:46:19Z

Hi, if I install opencv-python-headless first, and then run

pip install mmcv

Then it also installs opencv-python and i end up with both versions installed. This gives me errors when I try to run python test.py for example.

Any suggestion on how to install mmcv so that it detects that I have the headless library already installed and avoids installing the non-headless?

DXist · 2019-12-21T11:27:42Z

There is inconsistency: albumentations checks for regular opencv-python version and installs headless variant by default, mmcv does the opposite: checks for headless version and installs regular one by default.

Visualization can be viewed as an extra feature. If someone needs it then he/she could install regular opencv-python and related dependencies.
I think opencv-python-headless is a good default with less dependencies.

OpenMMLab-Assistant-004 · 2023-04-03T10:00:00Z

Hi @DXist ！First of all, we want to express our gratitude for your significant PR in the mmcv project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

OpenMMLab-Assistant-004 · 2023-04-03T10:03:30Z

Hi @DXist ！First of all, we want to express our gratitude for your significant PR in the mmcv project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/raweFPmdzG

If you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：）
Thank you again for your contribution❤

fix requirements

2ebec0d

don't reuse build dependencies between different envs

e60be4e

DXist force-pushed the feature/fix_dependencies branch from 265556d to e60be4e Compare October 30, 2019 17:59

DXist mentioned this pull request Oct 30, 2019

Albumentations augs wrapper open-mmlab/mmdetection#1354

Merged

hellock reviewed Nov 9, 2019

View reviewed changes

hellock mentioned this pull request Nov 10, 2019

Dependency on python-opencv-headless #127

Closed

hellock added 2 commits November 17, 2019 15:18

minor fix

31a11b9

change the order of opencv and opencv-headless

5705b06

hellock mentioned this pull request Nov 21, 2019

Update installation guide open-mmlab/mmdetection#1701

Merged

hellock approved these changes Nov 21, 2019

View reviewed changes

hellock merged commit aea7500 into open-mmlab:master Nov 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix dependencies #146

fix dependencies #146

DXist commented Oct 30, 2019

codecov bot commented Oct 30, 2019 •

edited

Loading

hellock Nov 9, 2019

hellock Nov 9, 2019

hellock commented Nov 9, 2019

hellock commented Nov 17, 2019

DXist commented Nov 17, 2019 •

edited

Loading

hellock commented Nov 18, 2019

DXist commented Nov 18, 2019

GiscardBiamby commented Dec 20, 2019

DXist commented Dec 21, 2019

OpenMMLab-Assistant-004 commented Apr 3, 2023

OpenMMLab-Assistant-004 commented Apr 3, 2023

fix dependencies #146

fix dependencies #146

Conversation

DXist commented Oct 30, 2019

codecov bot commented Oct 30, 2019 • edited Loading

Codecov Report

hellock Nov 9, 2019

Choose a reason for hiding this comment

hellock Nov 9, 2019

Choose a reason for hiding this comment

hellock commented Nov 9, 2019

hellock commented Nov 17, 2019

DXist commented Nov 17, 2019 • edited Loading

hellock commented Nov 18, 2019

DXist commented Nov 18, 2019

GiscardBiamby commented Dec 20, 2019

DXist commented Dec 21, 2019

OpenMMLab-Assistant-004 commented Apr 3, 2023

OpenMMLab-Assistant-004 commented Apr 3, 2023

codecov bot commented Oct 30, 2019 •

edited

Loading

DXist commented Nov 17, 2019 •

edited

Loading