-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pandaset support #396
Add pandaset support #396
Conversation
- add 'evaluation' method - add 'name' key to predictions dict
Thanks a lot for adding the clear and well organized pandaset codes! Could you also provide the performance of baseline models (like PointPillar or SECOND or PV-RCNN) on the pandaset dataset to validate the correctness? You could refer to https://github.com/open-mmlab/OpenPCDet/blob/master/pcdet/datasets/waymo/waymo_dataset.py#L243-L244 and https://github.com/open-mmlab/OpenPCDet/blob/master/pcdet/datasets/waymo/waymo_dataset.py#L176-L188 to support evaluation with KITTI tools. By the way, we have also internally supported the pandaset previously, and may add some modifications to the pandaset dataloader after merging your codes to the master. |
Unfortunately, I won't be able to provide Kitti evaluation code support nor trained models or performance of baseline models as it is out of my scope, I'll only be able to provide support on the existing parts of this code. |
Hi, Sorry for the late reply after one year.... I will merge this PR since it seems independent with the whole codebase and will not affect other parts. I also do not have much time to support several models for pandaset, and may leave this problem to others who will use it. PullRequest is welcomed for anybody who would like to support the evaluation / models on pandaset. |
Hello, could u please tell me the function meaning of ego_points = ps.geometry.lidar_points_to_ego(points_loc, pose) of the dataset.py ?☺ |
Hi, this function is from the pandaset API (https://github.com/scaleapi/pandaset-devkit/blob/master/python/pandaset/geometry.py#L53). Its aim is to move the points from the "global" reference system to the one of the sensor so that the processing of the frame does not depend on its location on the acquisition trajectory. |
@lea-v in pandaset_dataset.py
but i checked pandaset API, there is no lidar_points_to_ego... thanks. |
@Leozyc-waseda I'm trying to do something similar and it looks like that function is available in an open PR to pandaset-devkit:
|
@doronser |
Hello,
thanks a lot for sharing this project!
I've worked on adding support for Pandaset.
This code enables training and inferring frame by frame (not using whole sequences for the moment) on datasets in Pandaset format, however it does not enable evaluating results as there is no standard evaluation metric yet.
As you seem to be considered for further developments (#359), I think this could be useful for a starting point.
Please let me know if this can be of any use, and what could help merging this code.